Skip to content

Changes SplittableDoFn to call TruncateRestriction on drain - #39535

Open
acrites wants to merge 2 commits into
apache:masterfrom
acrites:truncate
Open

Changes SplittableDoFn to call TruncateRestriction on drain#39535
acrites wants to merge 2 commits into
apache:masterfrom
acrites:truncate

Conversation

@acrites

@acrites acrites commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Previous behavior was to call processElement on the currentRestriction and then not set any continuation timers (which causes the pipeline to eventually complete draining). With this change, we instead first call the DoFn's TruncateRestriction method. The default behavior for unbounded restrictions is to return null, which should finish immediately without processing. If the method returns a non-null residual restriction, we pass that to ProcessElement.

Also added some unit tests verifying that the default TruncateRestriction is used, or that the overridden one gets called.

This mimics the behavior of the FnApi harness found here:

.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

acrites added 2 commits July 28, 2026 15:04
… a timer caused by drain. We then pass the residual restriction (if present) to ProcessElement.
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant