fix(dataframe): claim remaining restriction range on empty/header-only CSV reads - #39581
Open
ManvithPanyam wants to merge 1 commit into
Open
fix(dataframe): claim remaining restriction range on empty/header-only CSV reads#39581ManvithPanyam wants to merge 1 commit into
ManvithPanyam wants to merge 1 commit into
Conversation
…y CSV reads Signed-off-by: ManvithPanyam <250704031+ManvithPanyam@users.noreply.github.com>
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
|
Assigning reviewers: R: @tvalentyn for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first contribution to Apache Beam — happy to adjust the approach if there's a preferred pattern I'm missing.
What broke?
When reading an empty or header-only CSV file using
beam.io.ReadFromCsv, the pipeline fails with:ValueError: OffsetRestrictionTracker is not done since work in range [0, 16) has not been claimed.
Root Cause
In
sdks/python/apache_beam/dataframe/io.py,_TruncatingFileHandle._read()returns early on an empty buffer without claiming the remaining restriction range, causingcheck_done()to fail.Fix
Verification
Added
test_empty_csv_readtoIOTest. Full suite (36 tests) passes with the fix; fails without it. Pre-existing Windows-only failures are unrelated (#20642).