Fix OpenTelemetry dependencies in published POMs - #39608
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #39608 +/- ##
============================================
- Coverage 58.15% 57.11% -1.04%
+ Complexity 13085 3641 -9444
============================================
Files 2521 1189 -1332
Lines 264850 191890 -72960
Branches 10788 3815 -6973
============================================
- Hits 154017 109598 -44419
+ Misses 105055 78773 -26282
+ Partials 5778 3519 -2259
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Assigning reviewers: R: @kennknowles for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
stankiewicz
left a comment
There was a problem hiding this comment.
thanks for spotting and fixing that
Recent OpenTelemetry tracing changes added versionless
opentelemetry-apidependencies to GCP and Kafka IO without importing the corresponding BOM. Their published snapshot POMs became invalid, so Maven discarded transitive dependencies and the PostRelease examples archetype failed to compile with missing Avro and GCP classes.Import the OpenTelemetry BOM in both modules so generated POMs provide the required dependency management.
Addresses #38714.
Testing:
mvn validatebecauseopentelemetry-apihas no version.mvn validateand importopentelemetry-bom-alpha.-Pspark-runner, matching the failing PostRelease profile.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md