From 5182aecf5530f835729d6cc98fb59626d834f069 Mon Sep 17 00:00:00 2001 From: SubramanyaV Date: Tue, 21 Apr 2026 12:38:00 +0530 Subject: [PATCH 1/4] fix pipeline result naming in Dataflow runner --- .../beam/runners/dataflow/DataflowPipelineJob.java | 5 +++++ .../java/org/apache/beam/sdk/PipelineResult.java | 13 +++++++++++++ 2 files changed, 18 insertions(+) diff --git a/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineJob.java b/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineJob.java index 400f161dee2f..638e886f6451 100644 --- a/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineJob.java +++ b/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineJob.java @@ -57,6 +57,11 @@ "nullness", // TODO(https://github.com/apache/beam/issues/20497) "Slf4jDoNotLogMessageOfExceptionExplicitly", // intended, sent full stacktrace to LOG.debug }) +/** + * Dataflow implementation of {@link PipelineResult}. + * + *

Note: This class represents a PipelineResult but uses a different name for historical reasons. + */ public class DataflowPipelineJob implements PipelineResult { private static final Logger LOG = LoggerFactory.getLogger(DataflowPipelineJob.class); diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/PipelineResult.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/PipelineResult.java index 91313f3924aa..bbe5856960bc 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/PipelineResult.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/PipelineResult.java @@ -25,6 +25,19 @@ * Result of {@link Pipeline#run()}. * *

This is often a job handle to an underlying data processing engine. + * + *

Different runners provide their own implementations of this interface. However, the naming of + * these implementations is not consistent across runners. + * + *

+ * + *

All of the above represent implementations of {@link PipelineResult}, even if their names do + * not explicitly include "PipelineResult". */ public interface PipelineResult { From 3570b25d2e44f698bdf20fe04935af07264b87fc Mon Sep 17 00:00:00 2001 From: SubramanyaV Date: Tue, 21 Apr 2026 20:01:17 +0530 Subject: [PATCH 2/4] Address review feedback: simplify Pipelineresult docs --- .../core/src/main/java/org/apache/beam/sdk/PipelineResult.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/PipelineResult.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/PipelineResult.java index bbe5856960bc..420e3ab4a5de 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/PipelineResult.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/PipelineResult.java @@ -26,9 +26,6 @@ * *

This is often a job handle to an underlying data processing engine. * - *

Different runners provide their own implementations of this interface. However, the naming of - * these implementations is not consistent across runners. - * *