From 7e0ec83d11f8c013ed644f86770613ec9f09ee5a Mon Sep 17 00:00:00 2001 From: Simone Chiorazzo Date: Thu, 8 Oct 2020 14:49:23 +0200 Subject: [PATCH 1/4] Require a grpcio version that is minor of 1.28. This allow to install the 1.27.2 that has pre-compiled wheel for python 3.8 on mac os --- stream/clients/python/setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stream/clients/python/setup.py b/stream/clients/python/setup.py index 172545ba9e8..ba50ad9666f 100644 --- a/stream/clients/python/setup.py +++ b/stream/clients/python/setup.py @@ -32,7 +32,7 @@ 'six>=1.10.0', 'pytz', 'futures>=3.2.0;python_version<"3.2"', - 'grpcio<1.26.0,>=1.8.2', + 'grpcio<1.28,>=1.8.2', 'pymmh3>=0.0.3' ] extras = { From 808e40e27b242f711533be4e6e8253f6863ae64b Mon Sep 17 00:00:00 2001 From: Simone Chiorazzo Date: Thu, 8 Oct 2020 15:14:53 +0200 Subject: [PATCH 2/4] Require the latest version of pymmh3 due to the signature change --- stream/clients/python/setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stream/clients/python/setup.py b/stream/clients/python/setup.py index ba50ad9666f..7d949ee469f 100644 --- a/stream/clients/python/setup.py +++ b/stream/clients/python/setup.py @@ -33,7 +33,7 @@ 'pytz', 'futures>=3.2.0;python_version<"3.2"', 'grpcio<1.28,>=1.8.2', - 'pymmh3>=0.0.3' + 'pymmh3>=0.0.5' ] extras = { } From d0b076c9ee5a66fa4da6a40242dfef1abcacf633 Mon Sep 17 00:00:00 2001 From: Simone Chiorazzo Date: Thu, 8 Oct 2020 15:15:09 +0200 Subject: [PATCH 3/4] Add test for python 3.8 --- stream/clients/python/scripts/test.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/stream/clients/python/scripts/test.sh b/stream/clients/python/scripts/test.sh index df566303092..81ef1a58c96 100755 --- a/stream/clients/python/scripts/test.sh +++ b/stream/clients/python/scripts/test.sh @@ -19,6 +19,7 @@ set -e -x -u SCRIPT_DIR=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd ) +PY_VERSION="3.8" NOXSESSION="unit" ${SCRIPT_DIR}/docker_tests.sh PY_VERSION="3.7" NOXSESSION="lint,lint_setup_py,unit" ${SCRIPT_DIR}/docker_tests.sh PY_VERSION="3.6" NOXSESSION="unit" ${SCRIPT_DIR}/docker_tests.sh PY_VERSION="3.5" NOXSESSION="unit" ${SCRIPT_DIR}/docker_tests.sh From 93671b3c7591debbd81969e03b8342eebe413fb7 Mon Sep 17 00:00:00 2001 From: Simone Chiorazzo Date: Thu, 8 Oct 2020 15:17:16 +0200 Subject: [PATCH 4/4] Removed signed param because is not accepted anymore --- stream/clients/python/bookkeeper/common/router/router.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stream/clients/python/bookkeeper/common/router/router.py b/stream/clients/python/bookkeeper/common/router/router.py index f52ef645e54..8e67dc97df8 100644 --- a/stream/clients/python/bookkeeper/common/router/router.py +++ b/stream/clients/python/bookkeeper/common/router/router.py @@ -27,4 +27,4 @@ def __init__(self): return def getRoutingKey(self, key): - return mmh3.hash64(key, seed=__SEED__, signed=True)[0] + return mmh3.hash64(key, seed=__SEED__)[0]