Repository navigation
[backport camel-4.18.x] CAMEL-26335: camel-cometd - configure allowedTransports and disable callback-polling by default - #28562
Merged
Conversation
Contributor
|
CI fails to compile the test on Claude Code on behalf of davsclaus |
Contributor
|
Adapted the backport for
Antigravity on behalf of oscerd |
gnodet-bot
reviewed
Oct 28, 2026
gnodet-bot
left a comment
Contributor
There was a problem hiding this comment.
Both concerns from @davsclaus's review are addressed in the second commit (CAMEL-26335: adapt the backport to camel-4.18.x):
- junit5 import —
CometdAllowedTransportsTestnow correctly importsorg.apache.camel.test.junit5.CamelTestSupport(not junit6) ✅ - Missing doc section — The "Allowed Transports and JSONP" section is present in
cometd-component.adoc, and the upgrade guide entry is correctly placed under "Upgrading from 4.18.5 to 4.18.6" incamel-4x-upgrade-guide-4_18.adoc✅
Implementation review:
CometdEndpoint.java: newallowedTransportsparameter with sensible default ("websocket,long-polling"— excludes callback-polling/JSONP) and proper@UriParamannotationCometdComponent.java: correctly normalizes whitespace in transport names viaArrays.stream(...).map(String::trim).filter(!empty)- Test coverage: 3 integration tests exercising default-rejects-JSONP, default-allows-long-polling, and explicit-JSONP-opt-in scenarios
LGTM — clean backport.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
…Transports and disable callback-polling by default
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
…nent Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
davsclaus
force-pushed
the
backport/28555-to-camel-4.18.x
branch
from
October 29, 2026 06:23
d849397 to
87df313
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #28555
Cherry-pick of 44700f0 to camel-4.18.x.
Conflicts resolved automatically by backport bot agent.