Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor event admin #98

Closed
rlenferink opened this issue Sep 28, 2019 · 1 comment
Closed

Refactor event admin #98

rlenferink opened this issue Sep 28, 2019 · 1 comment
Labels
component/event-admin Categorizes an issue or PR relevant to the event admin. kind/improvement Categorizes issue or PR as related to improvements.
Milestone

Comments

@rlenferink
Copy link
Member

The event admin currently does not work anymore. Refactor the event admin so that it works again and that:

  • It created and export a event_admin_api interface library target containing the api
  • Update api so that for event admin no event struct is needed -> i.e. signature celix_status_t (postEvent)(event_admin_t *event_admin, const char *topic, propeties_t *props);
  • event admin api only contains a sendEvent and postEvent method.
  • For sendEvent and postEvent the caller is responsbile for freeing the properties
  • For postEvent the event admin will create a copy of the properties
  • The eventHandle api contains one method with the signature: celix_status_t (*handleEvent)(void *handle, const char *topic, const properties_t *props);
  • For event handler the topic and properties arguments are only ensure to be valid during the executing of the handleEvent method.

Original creation date: 09/Apr/2018
Reporter: @pnoltes

@rlenferink rlenferink added component/event-admin Categorizes an issue or PR relevant to the event admin. kind/improvement Categorizes issue or PR as related to improvements. labels Sep 28, 2019
@rlenferink rlenferink added this to the 3.0.0 milestone Sep 28, 2019
@PengZheng
Copy link
Contributor

Replaced by #515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/event-admin Categorizes an issue or PR relevant to the event admin. kind/improvement Categorizes issue or PR as related to improvements.
Projects
None yet
Development

No branches or pull requests

2 participants