fix

shwstppr · shwstppr · commit 21419d16618b · 2026-01-31T14:21:48.000+05:30
Signed-off-by: Abhishek Kumar &lt;abhishek.mrt22@gmail.com&gt;
diff --git a/services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/template/UploadManagerImpl.java b/services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/template/UploadManagerImpl.java
@@ -349,8 +349,9 @@ public Answer handleDeleteEntityDownloadURLCommand(DeleteEntityDownloadURLComman
                 // FIXME - Ideally should bail out if you can't delete symlink. Not doing it right now.
                 // This is because the ssvm might already be destroyed and the symlinks do not exist.
                 logger.warn("Error in deleting symlink :" + result);
+            } else {
+                deleteEntitySymlinkRootPathIfNeeded(cmd, linkPath);
             }
-            deleteEntitySymlinkRootPathIfNeeded(cmd, linkPath);
         }
 
         // If its a volume or archive also delete the Hard link since it was created only for the purpose of download.

Original file line number	Diff line number	Diff line change
`@@ -349,8 +349,9 @@ public Answer handleDeleteEntityDownloadURLCommand(DeleteEntityDownloadURLComman`
`349`	`349`	`// FIXME - Ideally should bail out if you can't delete symlink. Not doing it right now.`
`350`	`350`	`// This is because the ssvm might already be destroyed and the symlinks do not exist.`
`351`	`351`	`logger.warn("Error in deleting symlink :" + result);`
	`352`	`+ } else {`
	`353`	`+ deleteEntitySymlinkRootPathIfNeeded(cmd, linkPath);`
`352`	`354`	`}`
`353`		`- deleteEntitySymlinkRootPathIfNeeded(cmd, linkPath);`
`354`	`355`	`}`
`355`	`356`
`356`	`357`	`// If its a volume or archive also delete the Hard link since it was created only for the purpose of download.`