Skip to content

Commit 4028c0b

Browse files
Slavka PelevaSlavka Peleva
authored andcommitted
addressed comments
1 parent 147c0b1 commit 4028c0b

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

test/integration/plugins/storpool/test_snapshot_copy_on_primary_storage.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ def test_06_take_snapshot_multi_zone_create_template_additional_zone(self):
257257

258258
@skipTestIf("testsNotSupported")
259259
@attr(tags=["devcloud", "advanced", "advancedns", "smoke", "basic", "sg"], required_hardware="false")
260-
def test_07_take_snapshot_multi_zone_deply_vm_additional_zone(self):
260+
def test_07_take_snapshot_multi_zone_deploy_vm_additional_zone(self):
261261
"""Test to take volume snapshot in multiple StorPool primary storages in diff zones and deploy a VM from snapshot in one of the additional zones
262262
"""
263263
snapshot = Snapshot.create(self.userapiclient, volume_id=self.volume.id, zoneids=[str(self.additional_zone.id)], usestoragereplication=True)
@@ -307,9 +307,9 @@ def create_volume_from_snapshot_deploy_vm(self, snapshotid, zoneid=None):
307307
volumeid=volume.id,
308308
mode="basic",
309309
)
310-
self._cleanup.append(virtual_machine)
310+
self.cleanup.append(virtual_machine)
311311
try:
312-
ssh_client = virtual_machine.get_ssh_client()
312+
virtual_machine.get_ssh_client()
313313
except Exception as e:
314314
self.fail("SSH failed for virtual machine: %s - %s" %
315315
(virtual_machine.ipaddress, e))
@@ -325,9 +325,9 @@ def deploy_vm_from_snapshot(self, snapshot, zoneid=None):
325325
snapshotid=snapshot.id,
326326
mode="basic",
327327
)
328-
self._cleanup.append(virtual_machine)
328+
self.cleanup.append(virtual_machine)
329329
try:
330-
ssh_client = virtual_machine.get_ssh_client()
330+
virtual_machine.get_ssh_client()
331331
except Exception as e:
332332
self.fail("SSH failed for virtual machine: %s - %s" %
333333
(virtual_machine.ipaddress, e))

test/integration/smoke/test_vm_lifecycle_with_snapshot_or_volume.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ def test_03_deploy_vm_with_existing_volume_deleted_template(self):
183183
mode="basic",
184184
)
185185
try:
186-
ssh_client = virtual_machine.get_ssh_client()
186+
virtual_machine.get_ssh_client()
187187
except Exception as e:
188188
self.fail("SSH failed for virtual machine: %s - %s" %
189189
(virtual_machine.ipaddress, e))
@@ -221,7 +221,7 @@ def test_04_deploy_vm_with_existing_snapshot_deleted_template(self):
221221
mode="basic",
222222
)
223223
try:
224-
ssh_client = virtual_machine.get_ssh_client()
224+
virtual_machine.get_ssh_client()
225225
except Exception as e:
226226
self.fail("SSH failed for virtual machine: %s - %s" %
227227
(virtual_machine.ipaddress, e))

0 commit comments

Comments
 (0)