Skip to content

Commit 4eda50e

Browse files
sliceofapplepienvazquez
authored andcommitted
fix null test
1 parent 63ae895 commit 4eda50e

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

plugins/acl/dynamic-role-based/src/test/java/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessCheckerTest.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@
4040
import com.cloud.user.UserVO;
4141

4242
import org.apache.cloudstack.acl.RolePermissionEntity.Permission;
43+
import org.apache.cloudstack.utils.cache.LazyCache;
44+
import com.cloud.utils.Pair;
4345

4446
import junit.framework.TestCase;
4547

@@ -234,6 +236,10 @@ public void testCheckAccessAccountUsesCachedPermissions() throws Exception {
234236
cachePeriodField.setAccessible(true);
235237
cachePeriodField.set(apiAccessCheckerSpy, 1);
236238

239+
Field rpCacheField = DynamicRoleBasedAPIAccessChecker.class.getDeclaredField("rolePermissionsCache");
240+
rpCacheField.setAccessible(true);
241+
rpCacheField.set(apiAccessCheckerSpy, new LazyCache<Long, Pair<Role, List<RolePermission>>>(32, 1, apiAccessCheckerSpy::getRolePermissions));
242+
237243
final String allowedApiName = "someAllowedApi";
238244
final RolePermission permission = new RolePermissionVO(1L, allowedApiName, Permission.ALLOW, null);
239245
Mockito.when(roleServiceMock.findAllPermissionsBy(Mockito.anyLong())).thenReturn(Collections.singletonList(permission));
@@ -301,6 +307,10 @@ public void testGetApisAllowedToAccountUsesCachedPermissions() {
301307
cachePeriodField.setAccessible(true);
302308
cachePeriodField.set(apiAccessCheckerSpy, 1);
303309

310+
Field rpCacheField = DynamicRoleBasedAPIAccessChecker.class.getDeclaredField("rolePermissionsCache");
311+
rpCacheField.setAccessible(true);
312+
rpCacheField.set(apiAccessCheckerSpy, new LazyCache<Long, Pair<Role, List<RolePermission>>>(32, 1, apiAccessCheckerSpy::getRolePermissions));
313+
304314
final RolePermission permission = new RolePermissionVO(1L, "api1", Permission.ALLOW, null);
305315
Mockito.when(roleServiceMock.findAllPermissionsBy(Mockito.anyLong())).thenReturn(Collections.singletonList(permission));
306316

0 commit comments

Comments
 (0)