Fixed: unnecessary regeneration of SSH keys in developer mode when they already existed. (#12059)

pavanaravapalli · web-flow · commit bac3421da437 · 2026-01-30T08:42:41.000+02:00
diff --git a/server/src/main/java/com/cloud/server/ConfigurationServerImpl.java b/server/src/main/java/com/cloud/server/ConfigurationServerImpl.java
@@ -614,7 +614,7 @@ public void updateKeyPairs() {
             }
             // FIXME: take a global database lock here for safety.
             boolean onWindows = isOnWindows();
-            if(!onWindows) {
+            if (!onWindows && !(privkeyfile.exists() && pubkeyfile.exists())) {
                 Script.runSimpleBashScript("if [ -f " + privkeyfile + " ]; then rm -f " + privkeyfile + "; fi; ssh-keygen -t ecdsa -m PEM -N '' -f " + privkeyfile + " -q 2>/dev/null || ssh-keygen -t ecdsa -N '' -f " + privkeyfile + " -q");
             }
 

Original file line number	Diff line number	Diff line change
`@@ -614,7 +614,7 @@ public void updateKeyPairs() {`
`614`	`614`	`}`
`615`	`615`	`// FIXME: take a global database lock here for safety.`
`616`	`616`	`boolean onWindows = isOnWindows();`
`617`		`- if(!onWindows) {`
	`617`	`+ if (!onWindows && !(privkeyfile.exists() && pubkeyfile.exists())) {`
`618`	`618`	`Script.runSimpleBashScript("if [ -f " + privkeyfile + " ]; then rm -f " + privkeyfile + "; fi; ssh-keygen -t ecdsa -m PEM -N '' -f " + privkeyfile + " -q 2>/dev/null \|\| ssh-keygen -t ecdsa -N '' -f " + privkeyfile + " -q");`
`619`	`619`	`}`
`620`	`620`