Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of Thread.sleep() #10486

Open
JaimeGarcia2005 opened this issue Feb 28, 2025 · 2 comments · May be fixed by #10504
Open

Use of Thread.sleep() #10486

JaimeGarcia2005 opened this issue Feb 28, 2025 · 2 comments · May be fixed by #10504
Milestone
unplanned

Comments

@JaimeGarcia2005
Copy link

problem

In the analysis of SonarCloud of this project, we can see that the function Thread.sleep() is used in the file engine/orchestration/src/main/java/com/cloud/agent/manager/DirectAgentAttache.java. This is a problem that can lead into big perfomance issues. If it was used the function wait() instead of it, the resources that CloudStack uses could be used by the computer to other programs until the wait finishes.

versions

No response

The steps to reproduce the bug

No response

What to do about it?

The code of the file engine/orchestration/src/main/java/com/cloud/agent/manager/DirectAgentAttache.java should be rewritten to be use the function wait() instead of the function Thread.sleep().
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Feb 28, 2025

Thanks for opening your first issue here! Be sure to follow the issue template!

@DaanHoogland
Copy link
Contributor

@JaimeGarcia2005 , you are right. happily awaiting any contribution to improve this.

@DaanHoogland DaanHoogland added this to the unplanned milestone Mar 3, 2025
@sroopsai sroopsai linked a pull request Mar 5, 2025 that will close this issue
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
unplanned
Development

Successfully merging a pull request may close this issue.

Refactor: Replace sleep() with wait() sroopsai/cloudstack
2 participants
@DaanHoogland @JaimeGarcia2005