Skip to content

refactor: avoid redundant DB calls when checking for root admin account #11390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shwstppr wants to merge 17 commits into
base: main
Choose a base branch
from

Merge branch 'main' into refactor-isrootadmin

7a96d5e
Select commit
Loading
Failed to load commit list.
Refresh
Open

refactor: avoid redundant DB calls when checking for root admin account #11390

Merge branch 'main' into refactor-isrootadmin
7a96d5e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 16, 2026 in 1s

17.89% (+14.22%) compared to a38205e

View this Pull Request on Codecov

17.89% (+14.22%) compared to a38205e

Details

Codecov Report

❌ Patch coverage is 20.95238% with 166 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.89%. Comparing base (a38205e) to head (7a96d5e).
⚠️ Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
...src/main/java/com/cloud/api/ApiResponseHelper.java 6.66% 14 Missing ⚠️
...ain/java/com/cloud/api/query/QueryManagerImpl.java 9.09% 9 Missing and 1 partial ⚠️
...ain/java/com/cloud/network/NetworkServiceImpl.java 9.09% 7 Missing and 3 partials ⚠️
...n/java/com/cloud/storage/VolumeApiServiceImpl.java 0.00% 8 Missing and 1 partial ⚠️
...c/main/java/com/cloud/user/AccountManagerImpl.java 57.14% 5 Missing and 4 partials ⚠️
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java 10.00% 8 Missing and 1 partial ⚠️
...ver/src/main/java/com/cloud/acl/DomainChecker.java 11.11% 8 Missing ⚠️
...n/java/com/cloud/template/TemplateManagerImpl.java 0.00% 7 Missing ⚠️
server/src/main/java/com/cloud/api/ApiServer.java 0.00% 5 Missing ⚠️
...ain/java/com/cloud/storage/StorageManagerImpl.java 28.57% 4 Missing and 1 partial ⚠️
... and 50 more
Additional details and impacted files 
@@             Coverage Diff              @@
##              main   #11390       +/-   ##
============================================
+ Coverage     3.67%   17.89%   +14.22%     
- Complexity       0    16088    +16088     
============================================
  Files          452     5936     +5484     
  Lines        38379   532589   +494210     
  Branches      7100    65146    +58046     
============================================
+ Hits          1410    95310    +93900     
- Misses       36783   426613   +389830     
- Partials       186    10666    +10480

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov