Skip to content

Update vpc.max.networks setting & settings to limit the number of NICs for each hypervisor #8654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hsato03 wants to merge 21 commits into
base: 4.22
Choose a base branch
from

fix tests

65b5f0c
Select commit
Loading
Failed to load commit list.
Refresh
Open

Update vpc.max.networks setting & settings to limit the number of NICs for each hypervisor #8654

fix tests
65b5f0c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 2, 2026 in 1s

17.63% (+0.01%) compared to b869913

View this Pull Request on Codecov

17.63% (+0.01%) compared to b869913

Details

Codecov Report

❌ Patch coverage is 67.56757% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.63%. Comparing base (b869913) to head (65b5f0c).

Files with missing lines Patch % Lines
...tack/engine/orchestration/NetworkOrchestrator.java 67.18% 20 Missing and 1 partial ⚠️
...m/cloud/api/query/dao/DomainRouterJoinDaoImpl.java 0.00% 12 Missing ⚠️
...ain/java/com/cloud/vm/dao/DomainRouterDaoImpl.java 0.00% 11 Missing ⚠️
...ain/java/com/cloud/network/vpc/VpcManagerImpl.java 92.98% 1 Missing and 3 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.22    #8654      +/-   ##
============================================
+ Coverage     17.62%   17.63%   +0.01%     
- Complexity    15663    15693      +30     
============================================
  Files          5915     5915              
  Lines        531171   531295     +124     
  Branches      64938    64950      +12     
============================================
+ Hits          93601    93700      +99     
- Misses       427031   427056      +25     
  Partials      10539    10539

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov