Skip to content

Commit 3fbd680

Browse files
viiryaclaude
andcommitted
fix: Address clippy warnings in Join::try_new
Fixed two clippy warnings: 1. doc_lazy_continuation: Added blank lines to properly separate doc comment paragraphs for the null_aware field documentation 2. too_many_arguments: Added #[expect(clippy::too_many_arguments)] attribute to Join::try_new since 8 parameters are necessary for complete join specification 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent e5d7dac commit 3fbd680

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

  • datafusion/expr/src/logical_plan

datafusion/expr/src/logical_plan/plan.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3785,9 +3785,11 @@ pub struct Join {
37853785
/// Defines the null equality for the join.
37863786
pub null_equality: NullEquality,
37873787
/// Whether this is a null-aware anti join (for NOT IN semantics).
3788+
///
37883789
/// Only applies to LeftAnti joins. When true, implements SQL NOT IN semantics where:
37893790
/// - If the right side (subquery) contains any NULL in join keys, no rows are output
37903791
/// - Left side rows with NULL in join keys are not output
3792+
///
37913793
/// This is required for correct NOT IN subquery behavior with three-valued logic.
37923794
pub null_aware: bool,
37933795
}
@@ -3812,6 +3814,7 @@ impl Join {
38123814
/// # Returns
38133815
///
38143816
/// A new Join operator with the computed schema
3817+
#[expect(clippy::too_many_arguments)]
38153818
pub fn try_new(
38163819
left: Arc<LogicalPlan>,
38173820
right: Arc<LogicalPlan>,

0 commit comments

Comments
 (0)