Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize sort_batch for single column case #14475

Open
Dandandan opened this issue Feb 4, 2025 · 1 comment
Open

Optimize sort_batch for single column case #14475

Dandandan opened this issue Feb 4, 2025 · 1 comment
Assignees
@2010YOUY01
Labels
enhancement New feature or request

Comments

@Dandandan
Copy link
Contributor

Is your feature request related to a problem or challenge?

sort_batch always uses multi column sort by sorting first to indices and then sorting the batch. See:

datafusion/datafusion/physical-plan/src/sorts/sort.rs

Line 628 in ea788c7

pub fn sort_batch(

We can use https://arrow.apache.org/rust/arrow/compute/fn.sort_limit.html instead

Describe the solution you'd like

For single row case, sort the batch directly instead of sorting multiple columns.

Describe alternatives you've considered

No response

Additional context

No response
@Dandandan Dandandan added the enhancement New feature or request label Feb 4, 2025
@Dandandan Dandandan changed the title Optimize sort_batch for single row case Optimize sort_batch for single column case Feb 4, 2025
@2010YOUY01
Copy link
Contributor

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2010YOUY01 2010YOUY01

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dandandan @2010YOUY01