Fix:c Median() truncates integers by returning Float64 for integer inputs #19582
+117
−48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19536 - Median() truncates integers
Rationale for this change:
The current implementation of median() returns the same type as the input. For integer inputs with an even count, this causes truncation when averaging the two middle values (e.g., median(1, 2, 3, 4) returns 2 instead of 2.5).
Changes in PR:
Test Coverage:
Yes - Updated existing sqllogictests in aggregate.slt and aggregate_skip_partial.slt to expect Float64 return types.
Are there any user-facing changes?
Yes - Breaking change: median() now returns Float64 instead of the input integer type for integer inputs. Users who relied on integer return types will need to cast explicitly if needed.