Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat](Nereids) support show authors command #43547

Merged
merged 1 commit into from
Nov 12, 2024
Merged

[Feat](Nereids) support show authors command #43547

merged 1 commit into from
Nov 12, 2024

Conversation

GentleCold
Copy link
Contributor

@GentleCold GentleCold commented Nov 10, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #42735

Problem Summary:

Check List (For Committer)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@GentleCold
Copy link
Contributor Author

run buildall

@GentleCold GentleCold force-pushed the show_authors branch 2 times, most recently from 4c00089 to 675e1e5 Compare November 10, 2024 17:47
@starocean999
Copy link
Contributor

run buildall

@GentleCold
Copy link
Contributor Author

run buildall

@GentleCold
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 51988 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a7d685095dcbf2508cadde57309a6f867666a304, data reload: false

------ Round 1 ----------------------------------
q1	17556	8096	7279	7279
q2	2592	1341	1176	1176
q3	9946	1139	1199	1139
q4	10229	880	825	825
q5	7630	2974	2954	2954
q6	232	143	147	143
q7	1045	611	615	611
q8	9380	2361	2364	2361
q9	12556	12572	12508	12508
q10	7164	2413	2476	2413
q11	472	266	263	263
q12	401	223	222	222
q13	17782	3067	3055	3055
q14	241	209	226	209
q15	577	533	504	504
q16	656	589	585	585
q17	981	539	545	539
q18	7344	6661	6799	6661
q19	1348	1020	982	982
q20	3078	2847	2830	2830
q21	4043	3396	3336	3336
q22	1410	1404	1393	1393
Total cold run time: 116663 ms
Total hot run time: 51988 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7535	7515	7843	7515
q2	350	245	241	241
q3	3079	3007	2981	2981
q4	2065	1778	1799	1778
q5	5667	5632	5710	5632
q6	215	136	136	136
q7	2175	1781	1816	1781
q8	3416	3535	3579	3535
q9	14724	14566	14508	14508
q10	3628	3573	3550	3550
q11	597	492	507	492
q12	836	598	604	598
q13	13137	3296	3139	3139
q14	296	263	280	263
q15	592	536	543	536
q16	686	652	637	637
q17	1842	1609	1615	1609
q18	8339	7783	7595	7595
q19	1676	1491	1615	1491
q20	2182	1976	1932	1932
q21	5438	5340	5266	5266
q22	665	556	593	556
Total cold run time: 79140 ms
Total hot run time: 65771 ms

@GentleCold
Copy link
Contributor Author

run buildall

@GentleCold GentleCold mentioned this pull request Nov 11, 2024
Closed
@GentleCold
Copy link
Contributor Author

run buildall

starocean999
starocean999 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@starocean999 starocean999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@starocean999 starocean999 merged commit 7c49c1a into apache:master Nov 12, 2024
26 of 28 checks passed
zzzxl1993 pushed a commit to zzzxl1993/doris that referenced this pull request Nov 12, 2024
@GentleCold @zzzxl1993
[Feat](Nereids) support show authors command (apache#43547)
5597589 
### What problem does this PR solve?

Issue Number: close apache#42735
py023 pushed a commit to py023/doris that referenced this pull request Nov 13, 2024
@GentleCold @py023
[Feat](Nereids) support show authors command (apache#43547)
398eb08 
### What problem does this PR solve?

Issue Number: close apache#42735
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiBinfeng-01 LiBinfeng-01 LiBinfeng-01 approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] (nereids)implement showAuthorsCommand in nereids
4 participants
@GentleCold @doris-robot @starocean999 @LiBinfeng-01