From 2d5d25e9312df25595cfdd68c26a92cb0826825f Mon Sep 17 00:00:00 2001 From: Roc Marshal Date: Sun, 26 Jan 2025 16:03:05 +0800 Subject: [PATCH] [hotfix][runtime] Remove the redundant JobVertex#hasNoConnectedInputs and use JobVertex#isInputVertex instead. --- .../main/java/org/apache/flink/runtime/jobgraph/JobGraph.java | 2 +- .../java/org/apache/flink/runtime/jobgraph/JobVertex.java | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java b/flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java index 9b862553252bb..551168ea4ef10 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java @@ -466,7 +466,7 @@ public List getVerticesSortedTopologicallyFromSources() while (iter.hasNext()) { JobVertex vertex = iter.next(); - if (vertex.hasNoConnectedInputs()) { + if (vertex.isInputVertex()) { sorted.add(vertex); iter.remove(); } diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobVertex.java b/flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobVertex.java index e2e3beb9270e6..022b3ca9775bf 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobVertex.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobVertex.java @@ -579,10 +579,6 @@ public boolean isOutputVertex() { return this.results.isEmpty(); } - public boolean hasNoConnectedInputs() { - return inputs.isEmpty(); - } - public void setSupportsConcurrentExecutionAttempts( boolean supportsConcurrentExecutionAttempts) { this.supportsConcurrentExecutionAttempts = supportsConcurrentExecutionAttempts;