Skip to content

Commit 2cc45d3

Browse files
committed
Move TrashPolicy#initialize out of getTrashPolicy
1 parent c722642 commit 2cc45d3

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3449,9 +3449,7 @@ public Collection<? extends BlockStoragePolicySpi> getAllStoragePolicies()
34493449
public TrashPolicy getTrashPolicy(Configuration conf) {
34503450
Class<? extends TrashPolicy> trashClass = conf.getClass(
34513451
"fs.trash.classname", TrashPolicyDefault.class, TrashPolicy.class);
3452-
TrashPolicy trashPolicy = ReflectionUtils.newInstance(trashClass, conf);
3453-
trashPolicy.initialize(conf, this); // initialize TrashPolicy
3454-
return trashPolicy;
3452+
return ReflectionUtils.newInstance(trashClass, conf);
34553453
}
34563454

34573455
/**

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicy.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,8 @@ public static TrashPolicy getInstance(Configuration conf, FileSystem fs, Path ho
167167
* @return an instance of TrashPolicy
168168
*/
169169
public static TrashPolicy getInstance(Configuration conf, FileSystem fs) {
170-
return fs.getTrashPolicy(conf);
170+
TrashPolicy trashPolicy = fs.getTrashPolicy(conf);
171+
trashPolicy.initialize(conf, fs); // initialize TrashPolicy
172+
return trashPolicy;
171173
}
172174
}

0 commit comments

Comments
 (0)