Skip to content

Commit 0535506

Browse files
author
ukumawat
committed
HBASE-28158 spotless apply
1 parent 8bd3bba commit 0535506

File tree

7 files changed

+10
-10
lines changed

7 files changed

+10
-10
lines changed

hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/AssignmentManagerStatusTmpl.jamon

Whitespace-only changes.

hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2007,7 +2007,7 @@ private void balanceThrottling(long nextBalanceStartTime, int maxRegionsInTransi
20072007
// But if there are zero regions in transition, it can skip sleep to speed up.
20082008
while (
20092009
!interrupted && EnvironmentEdgeManager.currentTime() < nextBalanceStartTime
2010-
&& this.assignmentManager.getOngoingTRSPCount()>0
2010+
&& this.assignmentManager.getOngoingTRSPCount() > 0
20112011
) {
20122012
try {
20132013
Thread.sleep(100);
@@ -2098,7 +2098,7 @@ public BalanceResponse balance(BalanceRequest request) throws IOException {
20982098

20992099
synchronized (this.balancer) {
21002100
// Only allow one balance run at at time.
2101-
if (this.assignmentManager.getOngoingTRSPCount() >0) {
2101+
if (this.assignmentManager.getOngoingTRSPCount() > 0) {
21022102
List<RegionStateNode> regionsInTransition = assignmentManager.getRegionsInTransition();
21032103
// if hbase:meta region is in transition, result of assignment cannot be recorded
21042104
// ignore the force flag in that case
@@ -2113,8 +2113,8 @@ public BalanceResponse balance(BalanceRequest request) throws IOException {
21132113

21142114
if (!request.isIgnoreRegionsInTransition() || metaInTransition) {
21152115
LOG.info("Not running balancer (ignoreRIT=false" + ", metaRIT=" + metaInTransition
2116-
+ ") because " + assignmentManager.getOngoingTRSPCount() + " region(s) in transition: " + toPrint
2117-
+ (truncated ? "(truncated list)" : ""));
2116+
+ ") because " + assignmentManager.getOngoingTRSPCount() + " region(s) in transition: "
2117+
+ toPrint + (truncated ? "(truncated list)" : ""));
21182118
return responseBuilder.build();
21192119
}
21202120
}

hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import edu.umd.cs.findbugs.annotations.NonNull;
2121
import java.io.IOException;
2222
import java.util.ArrayList;
23-
import java.util.Arrays;
2423
import java.util.Collection;
2524
import java.util.Collections;
2625
import java.util.Comparator;
@@ -2090,6 +2089,7 @@ public boolean isRegionInTransition(final RegionInfo regionInfo) {
20902089
public int getOngoingTRSPCount() {
20912090
return regionStates.getOngoingTRSPCount();
20922091
}
2092+
20932093
/**
20942094
* Get the number of regions in transition.
20952095
*/

hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManagerUtil.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ private static void unlock(List<RegionStateNode> regionNodes) {
9090

9191
static TransitRegionStateProcedure[] createUnassignProceduresForSplitOrMerge(
9292
MasterProcedureEnv env, Stream<RegionInfo> regions, int regionReplication) throws IOException {
93-
//TODO code to get all the replica
93+
// TODO code to get all the replica
9494
List<RegionStateNode> regionNodes = regions
9595
.flatMap(hri -> IntStream.range(0, regionReplication)
9696
.mapToObj(i -> RegionReplicaUtil.getRegionInfoForReplica(hri, i)))
@@ -282,7 +282,7 @@ static void reopenRegionsForRollback(MasterProcedureEnv env, List<RegionInfo> re
282282
static void removeNonDefaultReplicas(MasterProcedureEnv env, Stream<RegionInfo> regions,
283283
int regionReplication) {
284284
// Remove from in-memory states
285-
//TODO should we not confirm here that replica region are closed or not ?
285+
// TODO should we not confirm here that replica region are closed or not ?
286286
regions.flatMap(hri -> IntStream.range(1, regionReplication)
287287
.mapToObj(i -> RegionReplicaUtil.getRegionInfoForReplica(hri, i))).forEach(hri -> {
288288
env.getAssignmentManager().getRegionStates().deleteRegion(hri);

hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionInTransitionTracker.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ public boolean isRegionInTransition(final RegionInfo regionInfo) {
5252

5353
public void handleRegionStateNodeOperation(RegionStateNode regionStateNode) {
5454
RegionState.State currentState = regionStateNode.getState();
55-
//only consider default replica for availability
56-
if(regionStateNode.getRegionInfo().getReplicaId() != RegionInfo.DEFAULT_REPLICA_ID){
55+
// only consider default replica for availability
56+
if (regionStateNode.getRegionInfo().getReplicaId() != RegionInfo.DEFAULT_REPLICA_ID) {
5757
return;
5858
}
5959
// if region is merged or split it should not be in RIT list

hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ public boolean isRegionInRegionStates(final RegionInfo hri) {
105105
RegionStateNode createRegionStateNode(RegionInfo regionInfo) {
106106
synchronized (regionsMapLock) {
107107
RegionStateNode node = regionsMap.computeIfAbsent(regionInfo.getRegionName(),
108-
key -> new RegionStateNode(regionInfo,trspCounter));
108+
key -> new RegionStateNode(regionInfo, trspCounter));
109109

110110
if (encodedRegionsMap.get(regionInfo.getEncodedName()) != node) {
111111
encodedRegionsMap.put(regionInfo.getEncodedName(), node);

hbase-server/src/test/java/org/apache/hadoop/hbase/master/http/TestMasterStatusServlet.java

Whitespace-only changes.

0 commit comments

Comments
 (0)