Skip to content

Conversation

@liuxiaocs7
Copy link
Contributor

@liuxiaocs7 liuxiaocs7 commented Nov 3, 2025

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@liuxiaocs7 liuxiaocs7 closed this Nov 7, 2025
@liuxiaocs7 liuxiaocs7 reopened this Nov 7, 2025
@liuxiaocs7 liuxiaocs7 requested a review from Apache9 November 8, 2025 09:47
Copy link
Contributor

@vaijosh vaijosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache9
Copy link
Contributor

Apache9 commented Nov 20, 2025

Please fix the checkstyle issue?

@liuxiaocs7
Copy link
Contributor Author

liuxiaocs7 commented Nov 21, 2025

Please fix the checkstyle issue?

Hi, @Apache9, thank you for pointing it out. I missed it before and it has been fixed, let's wait for CI pass.

BTW, When running the mvn checkstyle:check locally, the build fails. Then using mvn checkstyle:checkstyle -DCheckstyle.mailOnViolation=false, we can see the number of every module check failures, total is 5060. The example output is shown below. Should we need to fix or modify the check rules to ensure that mvn checkstyle:check runs successfully.

[INFO] There are 3359 errors reported by Checkstyle 11.0.1 with hbase/checkstyle.xml ruleset.
image

@liuxiaocs7 liuxiaocs7 requested a review from Apache9 November 21, 2025 04:00
@Apache9
Copy link
Contributor

Apache9 commented Nov 21, 2025

Our goal is to not introduce new checkstyle issues, the above pre commit show that there is a line length issue introduced by the newly added code. Fix that issue is enough.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 46s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 5m 25s master passed
+1 💚 compile 5m 20s master passed
+1 💚 checkstyle 1m 24s master passed
+1 💚 spotbugs 2m 28s master passed
+1 💚 spotless 0m 58s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 40s the patch passed
+1 💚 compile 4m 8s the patch passed
+1 💚 javac 4m 8s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 9s the patch passed
+1 💚 spotbugs 1m 56s the patch passed
+1 💚 hadoopcheck 12m 33s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚 spotless 0m 46s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
48m 46s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7431/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7431
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 75ebef6ce0c6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b7bded5
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7431/4/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 2m 8s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 5m 18s master passed
+1 💚 compile 1m 21s master passed
+1 💚 javadoc 0m 43s master passed
+1 💚 shadedjars 7m 55s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 52s the patch passed
+1 💚 compile 1m 24s the patch passed
+1 💚 javac 1m 24s the patch passed
+1 💚 javadoc 0m 43s the patch passed
+1 💚 shadedjars 8m 29s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 503m 51s hbase-server in the patch passed.
541m 18s
Subsystem Report/Notes
Docker ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7431/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7431
Optional Tests javac javadoc unit compile shadedjars
uname Linux bb6ac8984672 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b7bded5
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7431/4/testReport/
Max. process+thread count 2651 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7431/4/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit 100cd23 into apache:master Nov 27, 2025
1 check passed
Apache9 pushed a commit that referenced this pull request Nov 27, 2025
…ntryBatch (#7431)

Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit 100cd23)
Apache9 pushed a commit that referenced this pull request Nov 27, 2025
…ntryBatch (#7431)

Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit 100cd23)
Apache9 pushed a commit that referenced this pull request Nov 27, 2025
…ntryBatch (#7431)

Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit 100cd23)
Apache9 pushed a commit that referenced this pull request Nov 27, 2025
…ntryBatch (#7431)

Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit 100cd23)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants