fixing comments, thanks all :)

Author: gabeiglio

pyiceberg/table/__init__.py

@@ -355,7 +355,7 @@ def _set_ref_snapshot(
         return updates, requirements
 
     def _build_partition_predicate(
-        self, partition_records: set[Record], spec: PartitionSpec | None = None, schema: Schema | None = None
+        self, partition_records: set[Record], spec: PartitionSpec, schema: Schema
     ) -> BooleanExpression:
         """Build a filter predicate matching any of the input partition records.
 
@@ -366,9 +366,7 @@ def _build_partition_predicate(
         Returns:
             A predicate matching any of the input partition records.
         """
-        partition_spec = spec or self.table_metadata.spec()
-        schema = schema or self.table_metadata.schema()
-        partition_fields = [schema.find_field(field.source_id).name for field in partition_spec.fields]
+        partition_fields = [schema.find_field(field.source_id).name for field in spec.fields]
 
         expr: BooleanExpression = AlwaysFalse()
         for partition_record in partition_records:
@@ -545,7 +543,9 @@ def dynamic_partition_overwrite(
         )
 
         partitions_to_overwrite = {data_file.partition for data_file in data_files}
-        delete_filter = self._build_partition_predicate(partition_records=partitions_to_overwrite)
+        delete_filter = self._build_partition_predicate(
+            partition_records=partitions_to_overwrite, spec=self.table_metadata.spec(), schema=self.table_metadata.schema()
+        )
         self.delete(delete_filter=delete_filter, snapshot_properties=snapshot_properties, branch=branch)
 
         with self._append_snapshot_producer(snapshot_properties, branch=branch) as append_files:

pyiceberg/table/update/snapshot.py

@@ -331,10 +331,7 @@ def _commit(self) -> UpdatesAndRequirements:
     def snapshot_id(self) -> int:
         return self._snapshot_id
 
-    def schema(self, schema_id: int | None = None) -> Schema:
-        if schema_id:
-            if schema := self._transaction.table_metadata.schema_by_id(schema_id):
-                return schema
+    def schema(self) -> Schema:
         return self._transaction.table_metadata.schema()
 
     def spec(self, spec_id: int) -> PartitionSpec:
@@ -381,10 +378,10 @@ def _build_delete_files_partition_predicate(self) -> None:
             group = partition_to_overwrite.setdefault(data_file.spec_id, set())
             group.add(data_file.partition)
 
-        for spec_id, data_files in partition_to_overwrite.items():
+        for spec_id, partition_records in partition_to_overwrite.items():
             self.delete_by_predicate(
                 self._transaction._build_partition_predicate(
-                    partition_records=data_files, schema=self.schema(), spec=self.spec(spec_id)
+                    partition_records=partition_records, schema=self.schema(), spec=self.spec(spec_id)
                 )
             )