Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display building numbers #931

Closed
bchapuis opened this issue Jan 31, 2025 · 6 comments · Fixed by #945
Closed

Display building numbers #931

bchapuis opened this issue Jan 31, 2025 · 6 comments · Fixed by #945
Labels
basemap good first issue Good for newcomers

Comments

@bchapuis
Copy link
Member

bchapuis commented Jan 31, 2025

Description: Display building numbers on points and polygons tagged with "building". I think we should do this at high zoom levels only (e.g. >= 16?).

Attachements:
Image

Files: https://github.com/apache/incubator-baremaps/tree/main/basemap/layers/building

@YongGoose
Copy link
Contributor

YongGoose commented Feb 2, 2025

@bchapuis

For other beginners, I will only focus on resolving #928 and this issue as the good first issues and won’t work on the rest.

It would be better for the community if multiple beginners work on resolving Good First Issues, rather than me solving all the issues myself 🙂

Once two issues are resolved, I plan to work on the following topics.

  • FlightAware: Developing highly customized maps for the airline industry
  • Camptocamp: Developing highly customized maps for emergency services in France.
  • Alternatively, I plan to introduce our project to Korean companies and get use case recommendations to work on.
  • etc

Thank you, as always!

@bchapuis
Copy link
Member Author

bchapuis commented Feb 2, 2025

Good idea! Do not hesitate to report issues along the journey as some documentation may need updates.

Flightaware's use case is already in beta and they developped some tools in go to accelerate vector tile exports. Maybe we can bring some of their ideas in our export command and perform some benchmarks. Here is an additional reference. I believe Camptocamp's usecase is related to intranet maps. I havn't seen those maps yet.

@YongGoose
Copy link
Contributor

Good idea! Do not hesitate to report issues along the journey as some documentation may need updates.

Flightaware's use case is already in beta and they developped some tools in go to accelerate vector tile exports. Maybe we can bring some of their ideas in our export command and perform some benchmarks. Here is an additional reference. I believe Camptocamp's usecase is related to intranet maps. I havn't seen those maps yet.

Thank you for the reference!

Accelerating the vector tile export speed is very interesting!
I'll analyze their approach and then write a detailed suggestion.

It would be great to discuss this on the mailing list or in an issue.

@bchapuis
Copy link
Member Author

bchapuis commented Feb 2, 2025

I already brought some stuff (the query used to generate the tiles should be approximately the same). I'm not sure if the performence gain is at the level of the driver or could be achieved at the application level.

@YongGoose
Copy link
Contributor

I already brought some stuff (the query used to generate the tiles should be approximately the same). I'm not sure if the performence gain is at the level of the driver or could be achieved at the application level.

Could you share the changes that have been made?
I’d like to check as well and see at which level the performance improvement is happening.

To contribute effectively to the project in the long run, I need to have a solid understanding of the overall structure.
Analyzing this would be a great learning experience for me in that regard. 😀

@bchapuis
Copy link
Member Author

bchapuis commented Feb 3, 2025

Yes, the changes mainly consisted in simplifications performed in the following file:

https://github.com/apache/incubator-baremaps/blob/main/baremaps-core/src/main/java/org/apache/baremaps/tilestore/postgres/PostgresTileStore.java

The query optimizer of postgres used to perform poorly on complex spatial queries and we were initially parsing and rewriting the queries. The query optimizer improved a lot recently (postgres 15+) and the SQL queries generated by the PostgresTileStore are now similar to what baremaps-exporter does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
basemap good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants