Skip to content

Commit f3d111c

Browse files
authored
Reject NaN disk space warning threshold on hot reload (#18326)
1 parent fe77cf1 commit f3d111c

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

‎iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/conf/CommonDescriptor.java‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -597,7 +597,9 @@ public double loadHotModifiedDiskSpaceWarningThreshold(final TrimProperties prop
597597
properties.getProperty(
598598
"disk_space_warning_threshold",
599599
String.valueOf(config.getDiskSpaceWarningThreshold())));
600-
if (diskSpaceWarningThreshold < 0 || diskSpaceWarningThreshold >= 1) {
600+
if (!Double.isFinite(diskSpaceWarningThreshold)
601+
|| diskSpaceWarningThreshold < 0
602+
|| diskSpaceWarningThreshold >= 1) {
601603
throw new IOException(
602604
CommonMessages.EXCEPTION_DISK_SPACE_WARNING_THRESHOLD_MUST_BE_IN_0_1_BUT_WAS_7B345766
603605
+ diskSpaceWarningThreshold

‎iotdb-core/node-commons/src/test/java/org/apache/iotdb/commons/conf/CommonDescriptorDiskSpaceWarningThresholdTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public void outOfRangeValueIsRejectedWithoutMutatingConfig() {
6262
final CommonDescriptor descriptor = CommonDescriptor.getInstance();
6363
final double original = descriptor.getConfig().getDiskSpaceWarningThreshold();
6464
try {
65-
for (final String badValue : new String[] {"1.0", "1.5", "-0.1"}) {
65+
for (final String badValue : new String[] {"NaN", "1.0", "1.5", "-0.1"}) {
6666
final TrimProperties properties = new TrimProperties();
6767
properties.setProperty(KEY, badValue);
6868
Assert.assertThrows(

0 commit comments

Comments
 (0)