Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CrankyTokenFilter to the Lucene.Net.Analysis namespace #1127

Open
1 task done
NightOwl888 opened this issue Jan 28, 2025 · 1 comment
Open
1 task done

Move CrankyTokenFilter to the Lucene.Net.Analysis namespace #1127

NightOwl888 opened this issue Jan 28, 2025 · 1 comment
Labels
good-first-issue Good for newcomers is:bug is:task A chore to be done pri:normal up-for-grabs This issue is open to be worked on by anyone
Milestone
4.8.0-beta00018

Comments

@NightOwl888
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Task description

CrankyTokenFilter was incorrectly placed in the Lucene.Net.TestFramework.Analysis.CrankyTokenFilter namespace. It should be moved to the Lucene.Net.Analysis namespace because it was in the org.apache.lucene.analysis package in Lucene.
@NightOwl888 NightOwl888 added good-first-issue Good for newcomers is:bug is:task A chore to be done pri:normal up-for-grabs This issue is open to be worked on by anyone labels Jan 28, 2025
@NightOwl888 NightOwl888 added this to the 4.8.0-beta00018 milestone Jan 28, 2025
@paulirwin
Copy link
Contributor

I was happy to see that this was caught by my in-progress work on the API comparison tool (#1022):

Image

(Namespace/Package mismatches show on either side as a missing type, unless a manual mapping override is added.)

To clarify the original issue, while it needs to be moved to the Lucene.Net.Analysis namespace, it still will be in the TestFramework project, and should not be moved to the Lucene.Net.Analysis.Common project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Good for newcomers is:bug is:task A chore to be done pri:normal up-for-grabs This issue is open to be worked on by anyone
Projects
None yet
Milestone
4.8.0-beta00018
Development

No branches or pull requests
2 participants
@NightOwl888 @paulirwin