[MJARSIGNER-62] additionalArguments should not have double quotes

[jira-importer]

Manfred Koch opened MJARSIGNER-62 and commented

Adding additional arguments to the jarsigner with the arguments option will be double qouted in the command line. That causes errors and should be avoided.

 

Example:

 

<arguments>-certchain c:\chain.crt</arguments>

 

Results in

c:\Jenkins\tools\hudson.model.JDK\jdk-1.8.0_144-windows-x64\jre\..\bin\jarsigner.exe -keystore NONE -storepass *** -storetype PKCS11 -providerClass sun.security.pkcs11.SunPKCS11 -providerArg C:\config.conf "-certchain c:\chain.crt" -tsa http://timestamp.digicert.com library.jar alias

That can't be executed. I check that manually on the system.

But without double qoutes

c:\Jenkins\tools\hudson.model.JDK\jdk-1.8.0_144-windows-x64\jre\..\bin\jarsigner.exe -keystore NONE -storepass *** -storetype PKCS11 -providerClass sun.security.pkcs11.SunPKCS11 -providerArg C:\config.conf -certchain c:\chain.crt -tsa http://timestamp.digicert.com library.jar alias

it is possible to execute the command. I have checked the source code of the AbstractJarsignerMojo. All additionalArguments should not be double quoted.

 

---

Affects: 3.0.0

Issue Links:

• MJARSIGNER-63 certchain should be supported by default

Remote Links:

• GitHub Pull Request #17