[MJARSIGNER-52] Cannot sign spring-boot 'fully executable' jar

[jira-importer]

Marc Wrobel opened MJARSIGNER-52 and commented

When I try to sign a spring-boot 'fully executable' jar (e.g. jar file that embeds an extra script at the front of the file - see https://docs.spring.io/spring-boot/docs/current/reference/html/deployment-install.html) the maven-jarsigner-plugin ignores the artifact to sign :

[INFO] --- maven-jarsigner-plugin:1.4:sign (sign) @ xxx ---
[INFO] Unsupported artifact xxx ignored
[INFO] 0 archive(s) processed

If I sign the same artifact with JDK's jarsigner or if I sign a 'regular' jar everything is fine.

---

Affects: 1.4

[jira-importer]

Marc Wrobel commented

I think the issue comes from the usage of the JarSignerUtil#isZipFile() method in AbstractJarsignerMojo (see http://grepcode.com/file/repo1.maven.org/maven2/org.apache.maven.plugins/maven-jarsigner-plugin/1.4/org/apache/maven/plugins/jarsigner/AbstractJarsignerMojo.java#AbstractJarsignerMojo.isZipFile%28org.apache.maven.artifact.Artifact%29).

[jira-importer]

Robert Scholte commented

Any idea what the fix should be?

[jira-importer]

Lasse Lindqvist commented

I don't see that the plugin should support signing the executable. Jarsigner can be run before spring-boot-maven-plugin is run with repackage goal. This can be achieved with lifecycle configuration or plugin ordering.