Skip to content

Conversation

@slawekjaranowski
Copy link
Member

Right now Maven 4 (same as 3) contains duplicated code to read update status, and due this in-JVM but also process wide synchronization is needed.

For start, drop Maven legacy code and use resolver component to perform reads.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Right now Maven 4 (same as 3) contains duplicated code to read
update status, and due this in-JVM but also process wide
synchronization is needed.

For start, drop Maven legacy code and use resolver component
to perform reads.
@slawekjaranowski
Copy link
Member Author

cherry pick from:

@cstamas
Copy link
Member

cstamas commented Nov 28, 2025

Looks good, will pass once Resolver 1.9.25 is out.

/**
* DefaultUpdateCheckManager
*/
@Component(role = UpdateCheckManager.class)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure would I migrate this from plx to sisu; moreover, undoing this change will make other UT changes unneeded (index scanning)

private static final String ERROR_KEY_SUFFIX = ".error";

public DefaultUpdateCheckManager() {}
@Inject
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make/leave this plain old plx component with field injection instead, and as said above, it will leave things less intrusive re UTs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants