Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Flink currentFetchEventTimeLag metric calculation is wrong when the datastream is completely blocked #4244

Open
1 of 2 tasks
xiangyuf opened this issue Sep 24, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@xiangyuf
Copy link
Contributor

xiangyuf commented Sep 24, 2024

Search before asking

  • I searched in the issues and found nothing similar.

Paimon version

master(8ac121a)

Compute Engine

Flink

Minimal reproduce step

Check the Flink currentFetchEventTimeLag metric for a completely blocked datastream. It will not grow over time. But the currentEmitEventTimeLag will continue to grow.

What doesn't meet your expectations?

The currentFetchEventTimeLag metric should grow over time even if the datastream is completely blocked.

Anything else?

The lastSplitUpdateTime will not update for a completely blocked datastream.
img_v3_02f1_22fc6ab6-2887-4dbd-94a6-fbb04603193g

In flink, the currentEmitEventTimeLag is calculated by idleTime or currentTime, so this metric can keep grow for a completely blocked datastream.
img_v3_02f1_226f7c12-7838-4cac-8453-2dc9e367812g

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@xiangyuf xiangyuf added the bug Something isn't working label Sep 24, 2024
@xiangyuf xiangyuf changed the title [Bug] CURRENT_FETCH_EVENT_TIME_LAG metric calculation is wrong when the datastream is completely blocked [Bug] Flink currentFetchEventTimeLag metric calculation is wrong when the datastream is completely blocked Sep 24, 2024
@qingfei1994
Copy link

Hi @xiangyuf, I'm wondering if currentFetchEventTimeLag need to increase when datastream is blocked, as another pr #4281 update the logic of emitEventTimeLag, the metrics will not increase when no new records are in. I'm not sure if the logic should be synced between this two metrics, currentFetchEventTimeLag and emitEventTimeLag.

@xiangyuf
Copy link
Contributor Author

@qingfei1994 Hi, I think this metric need to keep increase when datastream is blocked. In many cases, we may need this metric to trigger alarm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants