st: fix CI - clang-tidy performance checks and MSBuild proto ordering

Two PR #600 failures the reflectcpp fix exposed once the build got further:

Lint (clang-tidy, performance-* treated as errors) on lib/st/ClientImpl.cc:
- the std::move of the trivially-copyable TransactionPolicy constructor
  argument had no effect; take it by const reference and copy the member.
- the four not-yet-implemented create/subscribe stubs take their config by
  value (the sink the real implementation will move from) but do not consume
  it yet, so performance-unnecessary-value-param fired. Suppress it with a
  NOLINTNEXTLINE on each stub rather than churning the by-value signature the
  follow-up phases need (which would cascade const-ref up the builder chain).

Windows (Visual Studio generator) failed compiling ST_OBJECT_LIB with
"Cannot open include file: PulsarApi.pb.h": the st sources include the
generated proto header, and while linking PROTO_OBJECTS propagates its
include directory, the OBJECT->OBJECT link does not reliably order the build
under MSBuild, so the st sources compiled before the proto existed. Add an
explicit add_dependencies(ST_OBJECT_LIB PROTO_OBJECTS) (and the legacy
PULSAR_OBJECT_LIB equivalent) and the generated-dir include.

Verified: full local build + 83/83 pulsar-st-tests green; clang-format clean.
Signed-off-by: Matteo Merli <mmerli@apache.org>

Author: merlimat

lib/CMakeLists.txt

@@ -89,7 +89,17 @@ set_property(TARGET ST_OBJECT_LIB PROPERTY POSITION_INDEPENDENT_CODE 1)
 set_target_properties(ST_OBJECT_LIB PROPERTIES CXX_STANDARD 20 CXX_STANDARD_REQUIRED ON)
 if (INTEGRATE_VCPKG)
     target_link_libraries(ST_OBJECT_LIB PROTO_OBJECTS)
+    # The st sources #include the generated PulsarApi.pb.h. Linking PROTO_OBJECTS
+    # propagates its include dir, but the OBJECT->OBJECT link does not reliably
+    # order the build under the Visual Studio generator, so the st sources can
+    # compile before the proto is generated. Force the ordering explicitly.
+    add_dependencies(ST_OBJECT_LIB PROTO_OBJECTS)
+else ()
+    # Legacy (non-vcpkg) build generates the proto as part of PULSAR_OBJECT_LIB;
+    # ensure it exists before the st sources that include it compile.
+    add_dependencies(ST_OBJECT_LIB PULSAR_OBJECT_LIB)
 endif ()
+target_include_directories(ST_OBJECT_LIB PRIVATE ${LIB_AUTOGEN_DIR})
 target_include_directories(ST_OBJECT_LIB PUBLIC
     "${CMAKE_SOURCE_DIR}"
     "${CMAKE_SOURCE_DIR}/include"

lib/st/ClientImpl.cc

@@ -38,21 +38,28 @@ Future<T> notImplementedYet(const char* what) {
 
 }  // namespace
 
-ClientImpl::ClientImpl(pulsar::ClientImplPtr classicClient, TransactionPolicy transactionPolicy)
-    : classic_(std::move(classicClient)), transactionPolicy_(std::move(transactionPolicy)) {}
+ClientImpl::ClientImpl(pulsar::ClientImplPtr classicClient, const TransactionPolicy& transactionPolicy)
+    : classic_(std::move(classicClient)), transactionPolicy_(transactionPolicy) {}
 
+// The producer/consumer/transaction paths land in follow-up phases. Each takes
+// its config by value (the sink the real implementation will move from), but as
+// a stub it does not consume the config yet — hence the value-param suppressions.
+// NOLINTNEXTLINE(performance-unnecessary-value-param)
 Future<detail::ProducerCore> ClientImpl::createProducerAsync(ProducerConfig) {
     return notImplementedYet<detail::ProducerCore>("createProducer");
 }
 
+// NOLINTNEXTLINE(performance-unnecessary-value-param)
 Future<detail::StreamConsumerCore> ClientImpl::subscribeStreamAsync(StreamConsumerConfig) {
     return notImplementedYet<detail::StreamConsumerCore>("subscribeStream");
 }
 
+// NOLINTNEXTLINE(performance-unnecessary-value-param)
 Future<detail::QueueConsumerCore> ClientImpl::subscribeQueueAsync(QueueConsumerConfig) {
     return notImplementedYet<detail::QueueConsumerCore>("subscribeQueue");
 }
 
+// NOLINTNEXTLINE(performance-unnecessary-value-param)
 Future<detail::CheckpointConsumerCore> ClientImpl::createCheckpointConsumerAsync(CheckpointConsumerConfig) {
     return notImplementedYet<detail::CheckpointConsumerCore>("createCheckpointConsumer");
 }

lib/st/ClientImpl.h

@@ -44,7 +44,7 @@ namespace pulsar::st {
  */
 class ClientImpl {
    public:
-    ClientImpl(pulsar::ClientImplPtr classicClient, TransactionPolicy transactionPolicy);
+    ClientImpl(pulsar::ClientImplPtr classicClient, const TransactionPolicy& transactionPolicy);
 
     Future<detail::ProducerCore> createProducerAsync(ProducerConfig config);
     Future<detail::StreamConsumerCore> subscribeStreamAsync(StreamConsumerConfig config);