Fix potential data race in pendingItem.done() (#1347)

gunli · web-flow · commit 0ab28c229e4d · 2025-03-17T18:14:54.000+08:00
* fix potential data race in pendingItem.done()

* update

* use defer
diff --git a/pulsar/producer_partition.go b/pulsar/producer_partition.go
@@ -1741,8 +1741,10 @@ func (i *pendingItem) done(err error) {
 	if i.isDone {
 		return
 	}
+
 	i.isDone = true
-	buffersPool.Put(i.buffer)
+	// return the buffer to the pool after all callbacks have been called.
+	defer buffersPool.Put(i.buffer)
 	if i.flushCallback != nil {
 		i.flushCallback(err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -1741,8 +1741,10 @@ func (i *pendingItem) done(err error) {`
`1741`	`1741`	`if i.isDone {`
`1742`	`1742`	`return`
`1743`	`1743`	`}`
	`1744`	`+`
`1744`	`1745`	`i.isDone = true`
`1745`		`- buffersPool.Put(i.buffer)`
	`1746`	`+ // return the buffer to the pool after all callbacks have been called.`
	`1747`	`+ defer buffersPool.Put(i.buffer)`
`1746`	`1748`	`if i.flushCallback != nil {`
`1747`	`1749`	`i.flushCallback(err)`
`1748`	`1750`	`}`