Skip to content

Commit e5ad9fe

Browse files
committed
RANGER-5345: [GDS] Shared resource creation api is failing for oracle db
1 parent db1ea50 commit e5ad9fe

File tree

4 files changed

+14
-7
lines changed

4 files changed

+14
-7
lines changed

agents-common/src/main/java/org/apache/ranger/authorization/utils/JsonUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ public static List<RangerGdsMaskInfo> jsonToListGdsMaskInfo(String jsonStr) {
279279
try {
280280
return getMapper().readValue(jsonStr, TYPE_LIST_RANGER_GDS_MASK_INFO);
281281
} catch (Exception e) {
282-
LOG.error("Cannot get Map<String, RangerPolicyItemDataMaskInfo> from {}", jsonStr, e);
282+
LOG.error("Cannot get List<RangerGdsMaskInfo> from {}", jsonStr, e);
283283

284284
return null;
285285
}

security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -676,6 +676,10 @@ public List<RangerSharedResource> addSharedResources(List<RangerSharedResource>
676676
resource.setGuid(guidUtil.genGUID());
677677
}
678678

679+
if (resource.getSubResourceMasks() == null) {
680+
resource.setSubResourceMasks(new ArrayList<>());
681+
}
682+
679683
RangerSharedResource sharedResource = sharedResourceService.create(resource);
680684

681685
ret.add(sharedResource);

security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2047,6 +2047,7 @@ private Long getOrCreateDataShare(Long datasetId, Long serviceId, Long zoneId, S
20472047
dataShare.setTermsOfUse(rangerDataset.getTermsOfUse());
20482048
dataShare.setService(serviceName);
20492049
dataShare.setDefaultAccessTypes(new HashSet<>());
2050+
dataShare.setDefaultTagMasks(new ArrayList<>());
20502051

20512052
rangerDataShare = gdsStore.createDataShare(dataShare);
20522053

security-admin/src/main/resources/META-INF/jpa_named_queries.xml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2263,12 +2263,14 @@
22632263
</named-query>
22642264

22652265
<named-query name="XXGdsProject.findProjectsWithDataShareInStatus">
2266-
<query>SELECT DISTINCT obj FROM XXGdsProject obj, XXGdsDatasetInProject dip, XXGdsDataShareInDataset dshid
2267-
WHERE dshid.dataShareId = :dataShareId
2268-
AND dshid.status = :status
2269-
AND dip.datasetId = dshid.datasetId
2270-
AND dip.projectId = obj.id
2271-
AND dip.status = :status</query>
2266+
<query>SELECT obj FROM XXGdsProject obj
2267+
WHERE EXISTS (
2268+
SELECT 1 FROM XXGdsDatasetInProject dip, XXGdsDataShareInDataset dshid
2269+
WHERE dshid.dataShareId = :dataShareId
2270+
AND dshid.status = :status
2271+
AND dip.datasetId = dshid.datasetId
2272+
AND dip.projectId = obj.id
2273+
AND dip.status = :status)</query>
22722274
</named-query>
22732275

22742276
<named-query name="XXGdsProject.findServiceIds">

0 commit comments

Comments
 (0)