RANGER-5397: IllegalArgumentException in RangerRESTClient when no ran… #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger.plugin.<service>.policy.rest.url is configured
dhavalshah9131
requested review from
dineshkumar-yadav,
mneethiraj,
pradeepagrawal8184 and
rameeshm
rameeshm
reviewed
Nov 24, 2025
|
|
||
| setLastKnownActiveUrlIndex((new Random()).nextInt(getConfiguredURLs().size())); | ||
|
|
||
| int size = getConfiguredURLs().size(); |
Contributor
There was a problem hiding this comment.
Should we check on configuredURLs instead as it fetch the configured URLs? Also what is the impact of setting setLastKnownActiveUrlIndex(0); as there is no Url to call the end point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
RangerBasePlugin initialization fails with an IllegalArgumentException when the ranger.plugin..policy.rest.url property is not set.
The issue occurs because getConfiguredURLs() returns an empty list, causing Random.nextInt(0) to throw an exception.
How was this patch tested?
wrote a new test TestRangerRESTClient.testPluginInit_WithNoUrl_DoesNotCrash() this will fail without fix and pass with fix.