Fix review comments

Author: Kontinuation

rust/sedona-spatial-join/src/evaluated_batch/evaluated_batch_stream/evaluate.rs

@@ -160,3 +160,52 @@ pub(crate) fn create_evaluated_probe_stream(
         false,
     ))
 }
+
+#[cfg(test)]
+mod tests {
+    use std::sync::Arc;
+
+    use arrow_schema::{DataType, Field, Fields, Schema, SchemaRef};
+
+    use super::schema_contains_view_types;
+
+    fn schema(fields: Vec<Field>) -> SchemaRef {
+        Arc::new(Schema::new(fields))
+    }
+
+    #[test]
+    fn test_schema_contains_view_types_false() {
+        let schema = schema(vec![
+            Field::new("a", DataType::Int32, true),
+            Field::new("b", DataType::Utf8, true),
+        ]);
+
+        assert!(!schema_contains_view_types(&schema));
+    }
+
+    #[test]
+    fn test_schema_contains_view_types_true_top_level() {
+        let schema = schema(vec![
+            Field::new("a", DataType::Utf8View, true),
+            Field::new("b", DataType::BinaryView, true),
+        ]);
+
+        assert!(schema_contains_view_types(&schema));
+    }
+
+    #[test]
+    fn test_schema_contains_view_types_true_nested() {
+        let nested = Field::new(
+            "s",
+            DataType::Struct(Fields::from(vec![Field::new(
+                "v",
+                DataType::Utf8View,
+                true,
+            )])),
+            true,
+        );
+
+        let schema = schema(vec![nested]);
+        assert!(schema_contains_view_types(&schema));
+    }
+}

rust/sedona-spatial-join/src/utils/arrow_utils.rs

@@ -23,6 +23,7 @@ use arrow_array::ArrayRef;
 use arrow_array::StructArray;
 use arrow_schema::{ArrowError, DataType};
 use datafusion_common::Result;
+use sedona_common::sedona_internal_err;
 
 /// Reconstruct `batch` to organize the payload buffers of each `StringViewArray` and
 /// `BinaryViewArray` in sequential order by calling `gc()` on them.
@@ -117,7 +118,10 @@ pub(crate) fn compact_array(array: ArrayRef) -> Result<(ArrayRef, bool)> {
 
         let DataType::List(field) = list_array.data_type() else {
             // Defensive: this downcast should only succeed for DataType::List.
-            return Ok((array, false));
+            return sedona_internal_err!(
+                "ListArray has non-List data type: {:?}",
+                list_array.data_type()
+            );
         };
 
         let rebuilt = ListArray::new(