Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] A better approach to integrate AsyncProfiler parser #12736

Open
2 of 3 tasks
lujiajing1126 opened this issue Nov 1, 2024 · 1 comment
Open
2 of 3 tasks

[Feature] A better approach to integrate AsyncProfiler parser #12736

lujiajing1126 opened this issue Nov 1, 2024 · 1 comment
Labels
backend OAP backend related. enhancement Enhancement on performance or codes feature New feature
Milestone
10.2.0

Comments

@lujiajing1126
Copy link
Contributor

lujiajing1126 commented Nov 1, 2024 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Currently in the #12671, many classes are copied from the official AsyncProfiler repo in order to parse JFR.

But the copied files and their Licenses (headers) are not easy to be maintained.

A solution https://github.com/jvm-profiling-tools/ap-loader, which is mentioned by the author of AsyncProfiler may be considered.

Use case

No response

Related issues

#12671 (comment)

Are you willing to submit a pull request to implement this on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct
@lujiajing1126 lujiajing1126 added the feature New feature label Nov 1, 2024
@lujiajing1126 lujiajing1126 added this to the 10.2.0 milestone Nov 1, 2024
@wu-sheng wu-sheng added backend OAP backend related. enhancement Enhancement on performance or codes labels Nov 5, 2024
@wu-sheng
Copy link
Member

wu-sheng commented Nov 5, 2024

fyi @zhengziyi0117 as owner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend OAP backend related. enhancement Enhancement on performance or codes feature New feature
Projects
None yet
Milestone
10.2.0
Development

No branches or pull requests
2 participants
@lujiajing1126 @wu-sheng