Skip to content

Commit 6baa827

Browse files
committed
[SLING-12493] Progressive cleanup of test cases
* Updated sling-bundle-parent to version 48. * Upgraded test dependencies to the latest compatible versions. * Migrated unit tests to use Mockito 5.
1 parent e44af7a commit 6baa827

File tree

4 files changed

+37
-19
lines changed

4 files changed

+37
-19
lines changed

pom.xml

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<parent>
2525
<groupId>org.apache.sling</groupId>
2626
<artifactId>sling-bundle-parent</artifactId>
27-
<version>41</version>
27+
<version>48</version>
2828
<relativePath />
2929
</parent>
3030

@@ -142,16 +142,22 @@
142142
<scope>provided</scope>
143143
</dependency>
144144
<!-- Testing -->
145+
<dependency>
146+
<groupId>org.apache.sling</groupId>
147+
<artifactId>org.apache.sling.commons.osgi</artifactId>
148+
<version>2.4.2</version>
149+
<scope>test</scope>
150+
</dependency>
145151
<dependency>
146152
<groupId>org.apache.sling</groupId>
147153
<artifactId>org.apache.sling.jcr.resource</artifactId>
148-
<version>2.3.8</version>
154+
<version>3.3.2</version>
149155
<scope>test</scope>
150156
</dependency>
151157
<dependency>
152158
<groupId>org.apache.sling</groupId>
153159
<artifactId>org.apache.sling.commons.testing</artifactId>
154-
<version>2.1.0</version>
160+
<version>2.1.2</version>
155161
<scope>test</scope>
156162
<exclusions>
157163
<exclusion>
@@ -162,32 +168,32 @@
162168
</dependency>
163169
<dependency>
164170
<groupId>org.apache.sling</groupId>
165-
<artifactId>org.apache.sling.testing.osgi-mock</artifactId>
166-
<version>2.3.4</version>
171+
<artifactId>org.apache.sling.testing.osgi-mock.junit4</artifactId>
172+
<version>3.5.0</version>
167173
<scope>test</scope>
168174
</dependency>
169175
<dependency>
170176
<groupId>org.mockito</groupId>
171-
<artifactId>mockito-all</artifactId>
172-
<version>1.10.19</version>
177+
<artifactId>mockito-core</artifactId>
178+
<version>5.14.2</version>
173179
<scope>test</scope>
174180
</dependency>
175181
<dependency>
176182
<groupId>org.apache.jackrabbit</groupId>
177-
<artifactId>jackrabbit-api</artifactId>
178-
<version>2.19.2</version>
179-
<scope>test</scope>
183+
<artifactId>oak-jackrabbit-api</artifactId>
184+
<version>1.72.0</version>
185+
<scope>test</scope>
180186
</dependency>
181187
<dependency>
182188
<groupId>org.apache.jackrabbit</groupId>
183189
<artifactId>jackrabbit-jcr-commons</artifactId>
184-
<version>2.19.4</version>
190+
<version>2.19.6</version>
185191
<scope>test</scope>
186192
</dependency>
187193
<dependency>
188194
<groupId>org.apache.jackrabbit</groupId>
189195
<artifactId>jackrabbit-core</artifactId>
190-
<version>2.19.4</version>
196+
<version>2.19.6 </version>
191197
<scope>test</scope>
192198
</dependency>
193199
</dependencies>

src/test/java/org/apache/sling/scripting/javascript/RepositoryScriptingTestBase.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import org.apache.sling.commons.testing.jcr.RepositoryTestBase;
2626
import org.apache.sling.scripting.javascript.internal.ScriptEngineHelper;
2727

28-
2928
/** Base class for tests which need a Repository
3029
* and scripting functionality */
3130
public class RepositoryScriptingTestBase extends RepositoryTestBase {

src/test/java/org/apache/sling/scripting/javascript/internal/ScriptEngineHelper.java

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,9 @@
3333
import org.apache.sling.commons.testing.osgi.MockBundle;
3434
import org.apache.sling.commons.testing.osgi.MockComponentContext;
3535
import org.apache.sling.scripting.api.ScriptCache;
36-
import org.mockito.internal.util.reflection.Whitebox;
36+
import org.mockito.InjectMocks;
37+
import org.mockito.Mock;
38+
import org.mockito.MockitoAnnotations;
3739
import org.mozilla.javascript.Context;
3840
import org.mozilla.javascript.ScriptableObject;
3941
import org.mozilla.javascript.Wrapper;
@@ -43,19 +45,30 @@
4345

4446
/** Helpers to run javascript code fragments in tests */
4547
public class ScriptEngineHelper {
48+
4649
private static ScriptEngine engine;
47-
private static ScriptCache scriptCache = mock(ScriptCache.class);
50+
51+
@Mock
52+
private static ScriptCache scriptCache;
53+
54+
@Mock
55+
private static RhinoJavaScriptEngineFactoryConfiguration configuration;
56+
57+
@InjectMocks
58+
private RhinoJavaScriptEngineFactory factory;
59+
60+
public ScriptEngineHelper() {
61+
MockitoAnnotations.initMocks(this);
62+
}
4863

4964
public static class Data extends HashMap<String, Object> {
5065
}
5166

52-
private static ScriptEngine getEngine() {
67+
private ScriptEngine getEngine() {
5368
if (engine == null) {
5469
synchronized (ScriptEngineHelper.class) {
5570
final RhinoMockComponentContext componentContext = new RhinoMockComponentContext();
5671
final RhinoJavaScriptEngineFactoryConfiguration configuration = mock(RhinoJavaScriptEngineFactoryConfiguration.class);
57-
RhinoJavaScriptEngineFactory factory = new RhinoJavaScriptEngineFactory();
58-
Whitebox.setInternalState(factory, "scriptCache", scriptCache);
5972
factory.activate(componentContext, configuration);
6073
engine = factory.getScriptEngine();
6174
}

src/test/java/org/apache/sling/scripting/javascript/wrapper/ScriptableResourceTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
import org.apache.sling.api.resource.ValueMap;
4545
import org.apache.sling.api.wrappers.ValueMapDecorator;
4646
import org.apache.sling.commons.testing.sling.MockResourceResolver;
47-
import org.apache.sling.jcr.resource.JcrResourceConstants;
47+
import org.apache.sling.jcr.resource.api.JcrResourceConstants;
4848
import org.apache.sling.scripting.javascript.RepositoryScriptingTestBase;
4949
import org.apache.sling.scripting.javascript.internal.ScriptEngineHelper;
5050
import org.jetbrains.annotations.NotNull;

0 commit comments

Comments
 (0)