[SPARK-54280][SDP] Require pipeline checkpoint storage dir to be absolute path #52999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Could you make the CI happy?
[info] SinkExecutionSuite:
[info] - writing to external sink - memory sink *** FAILED *** (2 seconds, 65 milliseconds)
| }, | ||
| "PIPELINE_STORAGE_ROOT_INVALID" : { | ||
| "message" : [ | ||
| "Pipeline storage root must be an absolute path with a URI scheme (e.g., file://, s3a://, hdfs://). Got: `<storage_root>`." |
Contributor
There was a problem hiding this comment.
Suggested change
| "Pipeline storage root must be an absolute path with a URI scheme (e.g., file://, s3a://, hdfs://). Got: `<storage_root>`." | |
| "Pipeline storage root must be an absolute path with an URI scheme (e.g., file://, s3a://, hdfs://). Got: `<storage_root>`." |
...nes/src/test/scala/org/apache/spark/sql/pipelines/graph/PipelineUpdateContextImplSuite.scala
Outdated
Show resolved
Hide resolved
sryza
force-pushed
the
storage-location-absolute
branch
from
971c876 to
dd8d70a
Compare
Member
|
Thank you for updating. It seems that we have only 1 failure, @sryza . |
Contributor
Author
|
I keep thinking I've handled them all and then finding new ones 🤦 . Working on this. |
Member
|
There is one remaining failure. I locally verified that it's irrelevant and passes locally. |
dongjoon-hyun
approved these changes
Nov 13, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @sryza . Merged to master/4.1.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 13, 2025
…lute path ### What changes were proposed in this pull request? - Raises an error if the pipeline checkpoint storage dir is not an absolute path - Updated the init CLI to create and set a checkpoint storage dir as an absolute path ### Why are the changes needed? Prevent users from accidentally losing checkpoints. ### Does this PR introduce _any_ user-facing change? Yes, but to unreleased functionality. ### How was this patch tested? - New unit tests - Ran the init CLI and then ran pipeline with streaming table ### Was this patch authored or co-authored using generative AI tooling? Closes #52999 from sryza/storage-location-absolute. Authored-by: Sandy Ryza <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 4020794) Signed-off-by: Dongjoon Hyun <[email protected]>
Contributor
Author
|
Thanks @dongjoon-hyun ! |
Member
|
Hi, @sryza . This seems to be flaky and block other PRs. Please see the following. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 14, 2025
…t schema ### What changes were proposed in this pull request? Fixes the `EndToEndAPISuite`, which was broken by #52999. ### Why are the changes needed? For CI to pass ### Does this PR introduce _any_ user-facing change? No - test-only change. ### How was this patch tested? Ran tests. ### Was this patch authored or co-authored using generative AI tooling? Closes #53069 from sryza/end-to-end-storage-root. Authored-by: Sandy Ryza <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 14, 2025
…t schema ### What changes were proposed in this pull request? Fixes the `EndToEndAPISuite`, which was broken by #52999. ### Why are the changes needed? For CI to pass ### Does this PR introduce _any_ user-facing change? No - test-only change. ### How was this patch tested? Ran tests. ### Was this patch authored or co-authored using generative AI tooling? Closes #53069 from sryza/end-to-end-storage-root. Authored-by: Sandy Ryza <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 7599b2f) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Prevent users from accidentally losing checkpoints.
Does this PR introduce any user-facing change?
Yes, but to unreleased functionality.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?