From 533177a1271dad604fae000fbc334e01a94c7644 Mon Sep 17 00:00:00 2001 From: Amin Ghadersohi Date: Thu, 30 Jul 2026 17:12:02 +0000 Subject: [PATCH 1/2] fix(core): reduce metric expression log noise --- superset/utils/core.py | 2 +- tests/unit_tests/utils/map_type_tests.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/superset/utils/core.py b/superset/utils/core.py index 09129c64eed8..deb17ca80ccf 100644 --- a/superset/utils/core.py +++ b/superset/utils/core.py @@ -1797,7 +1797,7 @@ def get_metric_type_from_column(column: Any, datasource: Explorable) -> str: operation = match.group(1) return METRIC_MAP_TYPE.get(operation, "") - logger.warning("Unexpected metric expression type: %s", expression) + logger.debug("Unexpected metric expression type: %s", expression) return "" diff --git a/tests/unit_tests/utils/map_type_tests.py b/tests/unit_tests/utils/map_type_tests.py index b076880e1478..ac6ee39f4596 100644 --- a/tests/unit_tests/utils/map_type_tests.py +++ b/tests/unit_tests/utils/map_type_tests.py @@ -42,9 +42,9 @@ def test_column_with_invalid_operation(): metric = SqlMetric(metric_name="my_column", expression="INVALID(my_column)") datasource = MagicMock(metrics=[metric]) column = "my_column" - with patch("superset.utils.core.logger.warning") as mock_warning: + with patch("superset.utils.core.logger.debug") as mock_debug: assert (get_metric_type_from_column(column, datasource)) == "" - mock_warning.assert_called_once() + mock_debug.assert_called_once() def test_empty_datasource(): From e84f2e09d4a244b5b4289f876d2ffbcf624957bf Mon Sep 17 00:00:00 2001 From: Amin Ghadersohi Date: Fri, 31 Jul 2026 15:29:35 +0000 Subject: [PATCH 2/2] test(core): verify metric expression debug message --- tests/unit_tests/utils/map_type_tests.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/unit_tests/utils/map_type_tests.py b/tests/unit_tests/utils/map_type_tests.py index ac6ee39f4596..b1d770672ec1 100644 --- a/tests/unit_tests/utils/map_type_tests.py +++ b/tests/unit_tests/utils/map_type_tests.py @@ -44,7 +44,9 @@ def test_column_with_invalid_operation(): column = "my_column" with patch("superset.utils.core.logger.debug") as mock_debug: assert (get_metric_type_from_column(column, datasource)) == "" - mock_debug.assert_called_once() + mock_debug.assert_called_once_with( + "Unexpected metric expression type: %s", "INVALID(my_column)" + ) def test_empty_datasource():