Skip to content

Commit 36977fb

Browse files
committed
lint fix + throw error
1 parent 606ae73 commit 36977fb

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

zeppelin-web-angular/e2e/models/notebook-keyboard-page.ts

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,7 @@ export class NotebookKeyboardPage extends BasePage {
5353

5454
async navigateToNotebook(noteId: string): Promise<void> {
5555
if (!noteId) {
56-
console.error('noteId is undefined or null. Cannot navigate to notebook.');
57-
return;
56+
throw new Error('noteId is undefined or null. Cannot navigate to notebook.');
5857
}
5958
try {
6059
await this.page.goto(`/#/notebook/${noteId}`, { waitUntil: 'networkidle' });
@@ -70,9 +69,9 @@ export class NotebookKeyboardPage extends BasePage {
7069
await this.page.waitForTimeout(2000);
7170

7271
// Check if we at least have the notebook structure
73-
const hasNotebookStructure = await this.page.evaluate(() => {
74-
return document.querySelector('zeppelin-notebook, .notebook-content, [data-testid="notebook"]') !== null;
75-
});
72+
const hasNotebookStructure = await this.page.evaluate(
73+
() => document.querySelector('zeppelin-notebook, .notebook-content, [data-testid="notebook"]') !== null
74+
);
7675

7776
if (!hasNotebookStructure) {
7877
console.error('Notebook page structure not found. May be a navigation or server issue.');
@@ -667,7 +666,7 @@ export class NotebookKeyboardPage extends BasePage {
667666
try {
668667
// Try to get content directly from Monaco Editor's model first
669668
const monacoContent = await this.page.evaluate(() => {
670-
// tslint:disable-next-line:no-any
669+
// eslint-disable-next-line @typescript-eslint/no-explicit-any
671670
const win = window as any;
672671
if (win.monaco && typeof win.monaco.editor.getActiveEditor === 'function') {
673672
const editor = win.monaco.editor.getActiveEditor();
@@ -686,7 +685,7 @@ export class NotebookKeyboardPage extends BasePage {
686685
const angularContent = await this.page.evaluate(() => {
687686
const paragraphElement = document.querySelector('zeppelin-notebook-paragraph');
688687
if (paragraphElement) {
689-
// tslint:disable-next-line:no-any
688+
// eslint-disable-next-line @typescript-eslint/no-explicit-any
690689
const angular = (window as any).angular;
691690
if (angular) {
692691
const scope = angular.element(paragraphElement).scope();
@@ -740,7 +739,7 @@ export class NotebookKeyboardPage extends BasePage {
740739
try {
741740
// Try to set content directly via Monaco Editor API
742741
const success = await this.page.evaluate(newContent => {
743-
// tslint:disable-next-line:no-any
742+
// eslint-disable-next-line @typescript-eslint/no-explicit-any
744743
const win = window as any;
745744
if (win.monaco && typeof win.monaco.editor.getActiveEditor === 'function') {
746745
const editor = win.monaco.editor.getActiveEditor();

0 commit comments

Comments
 (0)