Skip to content

Commit 3aaaed0

Browse files
committed
fix broken test
1 parent ab09089 commit 3aaaed0

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

zeppelin-web-angular/e2e/models/published-paragraph-page.util.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@ export class PublishedParagraphTestUtil {
167167

168168
const controlPanel = newPage.locator('zeppelin-notebook-paragraph-control');
169169
await expect(controlPanel).toBeHidden();
170+
await newPage.close();
170171
}
171172

172173
async createTestNotebook(): Promise<{ noteId: string; paragraphId: string }> {

zeppelin-web-angular/e2e/models/theme.page.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,13 @@ export class ThemePage {
2828
}
2929

3030
async assertDarkTheme() {
31-
await expect(this.rootElement).toHaveClass(/dark/);
31+
await expect(this.rootElement).toHaveClass(/dark/, { timeout: 10000 });
3232
await expect(this.rootElement).toHaveAttribute('data-theme', 'dark');
3333
await expect(this.themeToggleButton).toHaveText('dark_mode');
3434
}
3535

3636
async assertLightTheme() {
37-
await expect(this.rootElement).toHaveClass(/light/);
37+
await expect(this.rootElement).toHaveClass(/light/, { timeout: 10000 });
3838
await expect(this.rootElement).toHaveAttribute('data-theme', 'light');
3939
await expect(this.themeToggleButton).toHaveText('light_mode');
4040
}

zeppelin-web-angular/e2e/tests/theme/dark-mode.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,13 @@ test.describe('Dark Mode Theme Switching', () => {
5050
await test.step('WHEN the user switches to dark mode', async () => {
5151
await themePage.setThemeInLocalStorage('dark');
5252
const newPage = await context.newPage();
53-
await newPage.goto(currentPage.url());
53+
await newPage.goto(currentPage.url(), { waitUntil: 'networkidle' });
5454
await waitForZeppelinReady(newPage);
5555

5656
// Update themePage to use newPage and verify dark mode
5757
themePage = new ThemePage(newPage);
5858
currentPage = newPage;
59+
await newPage.close();
5960
await themePage.assertDarkTheme();
6061
});
6162

0 commit comments

Comments
 (0)