-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[ZEPPELIN-6371] Convert published paragraph rendering to Micro Frontend(Angular to React) in New UI #5111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dididy
wants to merge
15
commits into
apache:master
Choose a base branch
from
dididy:feature/micro-frontend
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d444be to
e1495e3
Compare
e1495e3 to
3570159
Compare
9761cac to
f1e1605
Compare
f1e1605 to
8dc15e7
Compare
22176a7 to
e881057
Compare
e881057 to
c4d1a62
Compare
749d461 to
6e99d25
Compare
6e99d25 to
f41c0e3
Compare
f41c0e3 to
2f2b8d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Micro Frontend Migration(Angular to React) Proposal
Summary
Changes
1. React Micro-Frontend Project Setup
projects/zeppelin-react/.2. Component Implementation
New React Components:
PublishedParagraph: Main entry point for published paragraph rendering.SingleResultRenderer: Template for rendering single paragraph results.Renderers:
HTMLRenderer: Renders HTML content with sanitization.TextRenderer: Renders plain text with ANSI support.ImageRenderer: Renders image outputs.Visualizations:
TableVisualization: Table rendering with sorting, filtering, and export.VisualizationControls: Control panel for table operations.Common Components:
Loading: Loading state indicator.Empty: Empty state display.3. Angular Integration
paragraph.component.ts: Added React widget loading logic via Module Federation.paragraph.component.html: Added React container element.environment.ts/environment.prod.ts: AddedreactRemoteEntryUrlconfiguration.http://localhost:3001/remoteEntry.js/assets/react/remoteEntry.js4. Build Configuration
angular.json: Copy React build output to/assets/react/.webpack.config.js: Configured Module Federation plugin:publicPathproxy.conf.js: Updated proxy configuration.5. Package
License
This PR uses several open-source libraries. The
xlsx(v0.18.5) andtypescript(v4.6.4) packages are licensed under Apache-2.0, while all other dependencies and devDependencies (such asreact,react-dom,antd,@ant-design/icons, etc.) are licensed under MIT. The MIT license is more permissive than Apache-2.0, so including MIT-licensed packages does not violate Apache-2.0 terms. All packages may be used commercially, and license notices should be included when distributing the project.Technical Details
Module Federation Configuration
Usage
/notebook/{noteId}/paragraph/{paragraphId}?react=trueWhat type of PR is it?
Improvement
Todos
What is the Jira issue?
ZEPPELIN-6371
How should this be tested?
// Start Zeppelin Server ./mvnw clean install -DskipTests ./mvnw clean package -DskipTests ./bin/zeppelin-daemon.sh start // Start Zeppelin New UI Client cd zeppelin-web-angular nvm use npm i npm run startTextRenderer
http://localhost:4200/#/notebook/2EYDJKFFY/paragraph/20180118-122136_1299905608?react=true
TableVisualization
http://localhost:4200/#/notebook/2EYDJKFFY/paragraph/20180118-122136_1299905608?react=true
ImageRenderer
http://localhost:4200/#/notebook/2F1S9ZY8Z/paragraph/20180117-220535_590781730?react=true
HTMLRenderer - Table
http://localhost:4200/#/notebook/2F1S9ZY8Z/paragraph/paragraph_1580885453474_1167659991?react=true
HTMLRenderer - Script(Bokeh JS)
http://localhost:4200/#/notebook/2F1S9ZY8Z/paragraph/paragraph_1580885707198_-1652524072?react=true
Screenshots (if appropriate)
Questions: