fix: Multipart close delimiter parsing (#852)

Author: calvincestari

Tests/ApolloTests/DeferTests.swift

@@ -633,4 +633,48 @@ final class DeferTests: XCTestCase, MockResponseProvider {
     expect(requestCount).to(equal(2))
   }
 
+  func test__parsing__givenResponse_withDataAfterCloseDelimiter_shouldParseSuccessfully() async throws {
+    await registerRequestHandler(
+      responseData: """
+        
+        --graphql
+        content-type: application/json
+        
+        {
+          "hasNext": true,
+          "data": {
+            "show" : {
+              "__typename": "show",
+              "name": "The Scooby-Doo Show",
+              "characters": [
+                {
+                  "__typename": "Character",
+                  "name": "Scooby-Doo"
+                },
+                {
+                  "__typename": "Character",
+                  "name": "Shaggy Rogers"
+                },
+                {
+                  "__typename": "Character",
+                  "name": "Velma Dinkley"
+                }
+              ]
+            }
+          }
+        }
+        --graphql--
+        
+        """.crlfFormattedData()
+    )
+
+    let results = try await network.send(
+      query: TVShowQuery(),
+      fetchBehavior: .NetworkOnly,
+      requestConfiguration: RequestConfiguration(writeResultsToCache: false)
+    ).getAllValues()
+
+    expect(results.count).to(equal(1))
+  }
+
 }

Tests/ApolloTests/Network/AsyncHTTPResponseChunkSequenceTests.swift

@@ -53,7 +53,7 @@ class AsyncHTTPResponseChunkSequenceTests: XCTestCase, MockResponseProvider {
     return request
   }
 
-  func test__multipartResponse__givenBeginWith_Delimeter_Boundary_shouldParseOut() async throws {
+  func test__multipartResponse__givenBeginWith_Delimiter_Boundary_shouldParseOut() async throws {
     let url = URL(string: "http://www.test.com/multipart-single-chunk")!
     let boundary = "-"
     let multipartString = "\r\n--\(boundary)\r\nTest"
@@ -76,7 +76,7 @@ class AsyncHTTPResponseChunkSequenceTests: XCTestCase, MockResponseProvider {
     }.to(equal(expectedChunks))
   }
 
-  func test__multipartResponse__givenBeginWith_CRLF_Delimeter_Boundary_shouldParseOut() async throws {
+  func test__multipartResponse__givenBeginWith_CRLF_Delimiter_Boundary_shouldParseOut() async throws {
     let url = URL(string: "http://www.test.com/multipart-single-chunk")!
     let boundary = "-"
     let multipartString = "\r\n\r\n--\(boundary)\r\nTest"
@@ -122,7 +122,7 @@ class AsyncHTTPResponseChunkSequenceTests: XCTestCase, MockResponseProvider {
     }.to(equal(expectedChunks))
   }
 
-  func test__multipartResponse__givenEndWithCloseDelimeterAfterBoundary_shouldParseOutDelimeter() async throws {
+  func test__multipartResponse__givenEndWithCloseDelimiterAfterBoundary_shouldParseOutDelimiter() async throws {
     let url = URL(string: "http://www.test.com/multipart-single-chunk")!
     let boundary = "-"
     let multipartString = "\r\n--\(boundary)\r\nTest\r\n--\(boundary)--"
@@ -145,7 +145,7 @@ class AsyncHTTPResponseChunkSequenceTests: XCTestCase, MockResponseProvider {
     }.to(equal(expectedChunks))
   }
 
-  func test__multipartResponse__givenEndWithCRLF_Boundary_CloseDelimeter_shouldParseOutEnd() async throws {
+  func test__multipartResponse__givenEndWithCRLF_Boundary_CloseDelimiter_shouldParseOutEnd() async throws {
     let url = URL(string: "http://www.test.com/multipart-single-chunk")!
     let boundary = "-"
     let multipartString = "\r\n--\(boundary)\r\nTest\r\n\r\n--\(boundary)--"

apollo-ios/Sources/Apollo/ResponseParsing/AsyncHTTPResponseChunkSequence.swift

@@ -52,7 +52,7 @@ public struct AsyncHTTPResponseChunkSequence: AsyncChunkSequence {
       self.underlyingIterator = underlyingIterator
 
       if let boundaryString = boundary?.data(using: .utf8) {
-        self.boundary = Constants.Delimeter + boundaryString
+        self.boundary = Constants.Delimiter + boundaryString
       } else {
         self.boundary = nil
       }
@@ -86,7 +86,7 @@ public struct AsyncHTTPResponseChunkSequence: AsyncChunkSequence {
         buffer.removeFirst(Constants.CRLF.count)
       }
 
-      if buffer == Constants.CloseDelimeter {
+      if buffer.starts(with: Constants.CloseDelimiter) {
         buffer.removeAll()
       }
     }

apollo-ios/Sources/Apollo/ResponseParsing/MultipartResponseSpecificationParser.swift

@@ -27,13 +27,12 @@ enum MultipartResponseParsing {
   /// Carriage Return Line Feed
   static let CRLF: Data = Data([0x0D, 0x0A]) // "\r\n"
 
-  static let Delimeter: Data = CRLF + [0x2D, 0x2D] // "\r\n--"
+  static let Delimiter: Data = CRLF + [0x2D, 0x2D] // "\r\n--"
 
-  /// The delimeter that signifies the end of a multipart response.
+  /// The delimiter that signifies the end of a multipart response.
   ///
-  /// This should immediately follow a Delimeter + Boundary.
-  static let CloseDelimeter: Data = Data([0x2D, 0x2D]) // "--"
-
+  /// This should immediately follow a Delimiter + Boundary.
+  static let CloseDelimiter: Data = Data([0x2D, 0x2D]) // "--"
 
   struct DataLineIterator: IteratorProtocol {
     /// A double carriage return. Used as the separator between data lines within a multipart response chunk