Skip to content

Commit 6c774a1

Browse files
authored
Update launcher.py
1 parent 0879d2b commit 6c774a1

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/torchrunx/launcher.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,6 @@ def launch(
181181
else:
182182
e += f"{v.message['message']}\n"
183183
e += f"{v.message['extraInfo']['py_callstack']}\n\n"
184-
print_process.kill()
185184
raise RuntimeError(e)
186185
except:
187186
# kill all agents
@@ -191,9 +190,9 @@ def launch(
191190
hostname=agent_hostname,
192191
ssh_config_file=ssh_config_file,
193192
)
194-
print_process.kill()
195193
raise
194+
finally:
195+
print_process.kill()
196196

197-
print_process.kill() # TODO: or close?
198197
return_values: dict[int, Any] = dict(ChainMap(*[s.return_values for s in agent_statuses]))
199198
return return_values

0 commit comments

Comments
 (0)