Skip to content

Commit efc7696

Browse files
committed
serialize to bytes
1 parent a9f8c59 commit efc7696

File tree

2 files changed

+10
-13
lines changed

2 files changed

+10
-13
lines changed

pixi.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/torchrunx/utils/logging.py

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -195,25 +195,22 @@ class LoggingServerArgs:
195195
log_dir: str | os.PathLike
196196
log_level: int
197197

198-
def serialize(self) -> SerializedLoggingServerArgs:
198+
def serialize(self) -> bytes:
199199
"""Serialize :class:`LoggingServerArgs` for passing to a new process."""
200-
return SerializedLoggingServerArgs(args=self)
200+
return cloudpickle.dumps(self)
201201

202-
203-
class SerializedLoggingServerArgs:
204-
def __init__(self, args: LoggingServerArgs) -> None:
205-
self.bytes = cloudpickle.dumps(args)
206-
207-
def deserialize(self) -> LoggingServerArgs:
208-
return cloudpickle.loads(self.bytes)
202+
@staticmethod
203+
def deserialize(serialized: bytes) -> LoggingServerArgs:
204+
"""Deserialize bytes to :class:`LoggingServerArgs`."""
205+
return cloudpickle.loads(serialized)
209206

210207

211208
def start_logging_server(
212-
serialized_args: SerializedLoggingServerArgs,
209+
serialized_args: bytes,
213210
stop_event: EventClass,
214211
) -> None:
215212
"""Serve :class:`_LogRecordSocketReceiver` until stop event triggered."""
216-
args: LoggingServerArgs = serialized_args.deserialize()
213+
args = LoggingServerArgs.deserialize(serialized_args)
217214

218215
log_handlers = args.log_handlers
219216
if log_handlers is None:

0 commit comments

Comments
 (0)