Skip to content

Commit 29fea5a

Browse files
authored
Merge pull request #69 from app-sre/resources
Extract resources to parameter
2 parents ce26a9c + ad3879f commit 29fea5a

File tree

2 files changed

+9
-32
lines changed

2 files changed

+9
-32
lines changed

openshift/gabi.template.yaml

+6-20
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,7 @@ objects:
5757
failureThreshold: 3
5858
periodSeconds: 10
5959
successThreshold: 1
60-
resources:
61-
limits:
62-
memory: 64Mi
63-
requests:
64-
cpu: ${OAUTH_PROXY_CPU_REQUEST}
65-
memory: 20Mi
60+
resources: "${{OAUTH_PROXY_RESOURCES}}"
6661
args:
6762
- --https-address=:3000
6863
- --provider=openshift
@@ -157,12 +152,7 @@ objects:
157152
value: ${CONFIG_FILE_PATH}
158153
- name: REQUEST_TIMEOUT
159154
value: ${REQUEST_TIMEOUT}
160-
resources:
161-
requests:
162-
cpu: ${CPU_REQUEST}
163-
memory: ${MEMORY_REQUEST}
164-
limits:
165-
memory: ${MEMORY_LIMIT}
155+
resources: "${{RESOURCES}}"
166156
volumes:
167157
- name: gabi-tls
168158
secret:
@@ -233,12 +223,8 @@ parameters:
233223
value: latest
234224
- name: REPLICAS
235225
value: "1"
236-
- name: CPU_REQUEST
237-
value: 100m
238-
- name: MEMORY_REQUEST
239-
value: 128Mi
240-
- name: MEMORY_LIMIT
241-
value: 256Mi
226+
- name: RESOURCES
227+
value: '{"requests": {"memory": "128Mi", "cpu": "100m"}, "limits":{"memory": "256Mi"}}'
242228
- name: OPENSHIFT_ROUTER_TIMEOUT
243229
value: "600s"
244230
- name: OAUTH_PROXY_IMAGE_NAME
@@ -247,8 +233,8 @@ parameters:
247233
value: "4.14.0"
248234
- name: OAUTH_PROXY_UPSTREAM_TIMEOUT
249235
value: "300s"
250-
- name: OAUTH_PROXY_CPU_REQUEST
251-
value: 100m
236+
- name: OAUTH_PROXY_RESOURCES
237+
value: '{"requests": {"memory": "32Mi", "cpu": "100m"}, "limits":{"memory": "64Mi"}}'
252238
- name: DB_DRIVER
253239
value: pgx
254240
- name: DB_WRITE

openshift/post-deploy-tests.template.yaml

+3-12
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,7 @@ objects:
3636
env:
3737
- name: HOST
3838
value: ${GABI_INSTANCE}-internal.${NAMESPACE}.svc.cluster.local
39-
resources:
40-
requests:
41-
memory: ${MEMORY_REQUESTS}
42-
cpu: ${CPU_REQUESTS}
43-
limits:
44-
memory: ${MEMORY_LIMIT}
39+
resources: "${{RESOURCES}}"
4540
parameters:
4641
- name: NAMESPACE
4742
value: gabi
@@ -54,9 +49,5 @@ parameters:
5449
required: true
5550
- name: SERVICE_ACCOUNT
5651
value: "gabi-post-deploy-tests"
57-
- name: MEMORY_REQUESTS
58-
value: 128Mi
59-
- name: MEMORY_LIMIT
60-
value: 128Mi
61-
- name: CPU_REQUESTS
62-
value: 300m
52+
- name: RESOURCES
53+
value: '{"requests": {"cpu": "300m", "memory": "128Mi"}, "limits": {"memory": "128Mi"}}'

0 commit comments

Comments
 (0)