Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocketFrame should have a nice description #2828

Closed
weissi opened this issue Aug 6, 2024 · 2 comments
Closed

WebSocketFrame should have a nice description #2828

weissi opened this issue Aug 6, 2024 · 2 comments
Labels
good first issue Good for newcomers kind/bug Feature doesn't work as expected.

Comments

@weissi
Copy link
Member

weissi commented Aug 6, 2024

Expected behavior

WebSocketFrame.description outputs something nice.

Actual behavior

WebSocketFrame.description outputs something that's not nice at all

WebSocketFrame(_storage: NIOWebSocket.WebSocketFrame.(unknown context at $1084150f8)._Storage, maskKey: nil, firstByte: 138)

Steps to reproduce

  • print any WebSocketFrame
@weissi weissi added kind/bug Feature doesn't work as expected. good first issue Good for newcomers labels Aug 6, 2024
supersonicbyte added a commit to supersonicbyte/swift-nio that referenced this issue Sep 3, 2024
@supersonicbyte
Adding a nicer description for WebSocketFrame.
af95304 
Motivation:

Resolving the following issue: apple#2828

Modifications:

Making `WebSocketFrame` conform to `CustomStringConvertible`.

Result:

A nicer description for `WebSocketFrame`.
@supersonicbyte supersonicbyte mentioned this issue Sep 3, 2024
Merged
@supersonicbyte
Copy link
Contributor

Made a PR for this.

FranzBusch added a commit that referenced this issue Sep 4, 2024
@supersonicbyte @FranzBusch
Adding a nicer description for WebSocketFrame. (#2862)
74f7b1e 
### Motivation:

Resolving the following issue:
#2828

### Modifications:

Making `WebSocketFrame` conform to `CustomStringConvertible`.

### Result:

A nicer description for `WebSocketFrame`.

---------

Co-authored-by: Franz Busch <[email protected]>
@ali-ahsan-ali
Copy link
Contributor

Can this be closed?

@Lukasa Lukasa closed this as completed Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/bug Feature doesn't work as expected.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@weissi @Lukasa @ali-ahsan-ali @supersonicbyte