From eab2050f64dbbf3e59ef2d3d584140aeca9fe232 Mon Sep 17 00:00:00 2001 From: Ankita Kinger Date: Wed, 12 Mar 2025 11:40:00 +0530 Subject: [PATCH] addressing review comments --- .../src/ce/navigation/FocusStrategy/AppIDEFocusStrategy.ts | 2 +- app/client/src/ce/navigation/FocusStrategy/types.ts | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/app/client/src/ce/navigation/FocusStrategy/AppIDEFocusStrategy.ts b/app/client/src/ce/navigation/FocusStrategy/AppIDEFocusStrategy.ts index 3f47269b3b4..22587ef6fca 100644 --- a/app/client/src/ce/navigation/FocusStrategy/AppIDEFocusStrategy.ts +++ b/app/client/src/ce/navigation/FocusStrategy/AppIDEFocusStrategy.ts @@ -292,7 +292,7 @@ export const AppIDEFocusStrategy: FocusStrategy = { } // We do not have to add any query params because this url is used as the key - return parentUrl.split("?")[0] + `#${branch}`; + return `${parentUrl.split("?")[0]}#${branch}`; }, *waitForPathLoad(currentPath: string, previousPath?: string) { if (previousPath) { diff --git a/app/client/src/ce/navigation/FocusStrategy/types.ts b/app/client/src/ce/navigation/FocusStrategy/types.ts index b9abbf55601..541a1a620aa 100644 --- a/app/client/src/ce/navigation/FocusStrategy/types.ts +++ b/app/client/src/ce/navigation/FocusStrategy/types.ts @@ -33,7 +33,9 @@ export interface FocusStrategy { getEntityParentUrl: ( entityInfo: FocusEntityInfo, parentEntity: FocusEntity, - ) => Generator; + // TODO: Fix this the next time the file is edited + // eslint-disable-next-line @typescript-eslint/no-explicit-any + ) => Generator; /** Define a wait (saga) before we start setting states **/ waitForPathLoad: ( currentPath: string,