-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Bug Report: Too much padding above links #1741
Comments
Hello @stnguyen90 and @thejessewinton . I've tried resolving this issue with the PR #1749 . The fix can be confirmed from the screenshots below . Also the padding was needed at some places so I selectively ignored the top margins of links when it was inline in a paragraph making it visually pleasing. I would love to listen to your feedback and make improvements if required. |
Hello, @stnguyen90 and @thejessewinton . For resolving this issue I decided to selectively chose the links directly inside a paragraph so as to not affect any other kind of links as can be confirmed in #1749 . Whereas @thejessewinton with all due respect in the PR #1770 the whole style tag affecting all such links has been removed. I would humbly like to understand this code change. Thanks .. |
@sahilsekr42, thanks for creating this PR. Next time, please make sure you're assigned on the issue before working on it as we don't want people to waste time on a PR that doesn't get merged. |
Ok @stnguyen90 , and thanks for the suggestion will keep in mind next time. |
👟 Reproduction steps
Open a page with a link such as https://appwrite.io/changelog/entry/2025-01-17
👍 Expected behavior
There is no padding above the link
👎 Actual Behavior
There is padding:
🎲 Appwrite version
Appwrite Cloud
💻 Operating system
Linux
🧱 Your Environment
No response
👀 Have you spent some time to check if this issue has been raised before?
🏢 Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: