Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Trivy Flag Updates #2217

Closed
Hacks4Snacks opened this issue Aug 7, 2024 · 2 comments
Closed

feat: Trivy Flag Updates #2217

Hacks4Snacks opened this issue Aug 7, 2024 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed.

Comments

@Hacks4Snacks
Copy link
Contributor

Trivy has moved to deprecate the "slow" flag in favor of "parallel", as such we should start transitioning away from the "slow" flag. However, there is a question of backwards compatibility. For the PR that introduces "parallel", should "slow" be retained as a configuration option that maps to a default "parallel" setting or should "slow" be stripped completely?

Additionally, in the upcoming v0.55.0 Trivy will be introducing the "detection-priority" flag (reference: aquasecurity/trivy#7198) that we should expose as configurable in the Helm chart.

@Hacks4Snacks Hacks4Snacks added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

This issue is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Oct 7, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2024
@itaysk
Copy link

itaysk commented Oct 27, 2024

sorry for missing this, we take this kind of feedback under Discussions not Issues. Generally we have a process of announcing deprecation, allowing transitioning period, and supporting backwards compatibility for a while (in the case of flags using aliases). sometimes there are exceptions to this process due to legitimate reasons, and sometimes there are mistakes. but FTR, you are right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

2 participants